From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id A7388E004F6; Tue, 12 May 2015 11:06:35 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [209.85.212.175 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com [209.85.212.175]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 1206CE0027F for ; Tue, 12 May 2015 11:06:31 -0700 (PDT) Received: by wief7 with SMTP id f7so118382042wie.0 for ; Tue, 12 May 2015 11:06:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=jD/L9a1ZVvXUFdRvm+iQOYmKLroBipX3WqfibX1l0oA=; b=YDKQCZq6lBGi+T4rc3sQcPmu7sqiuhlrQBX/bnTMYImwfPlQUry6pbCwtlXSPnZms8 ycRQgsDoCEcJNWpVkzMehKPizmBt/X9nMi24/tzQfSmgLjMa44RQ3ve5iaaK83NJrD8S sLjw9CYutonZhLdyEUEUNcF29FpX7l0YbSVBNhv4/4KzPlf5YYKVeDk2TMZtV/uW6qWs 8wDi5O74mBIgGgdDvS4VFZmMuR4mcojZmYOsYf4wSvycGAX/UarVQaO2gUFP7Dmb3gzr fyQse8zKcU0n8gI/WU9BWQ4I51ljEuX8lyA0aX+CEZfgL620HLeii3AcVfE6GBc53Mgg lIlg== X-Gm-Message-State: ALoCoQk8kbr1TFEwq3K2U6MbZj/QVoFEQjHAo1P/1sxHYthYITL8+YczeQY9huBnGoffYGjzxq6c X-Received: by 10.194.9.161 with SMTP id a1mr32772615wjb.39.1431453989984; Tue, 12 May 2015 11:06:29 -0700 (PDT) Received: from [192.168.2.74] ([83.217.123.106]) by mx.google.com with ESMTPSA id gy8sm3996039wib.13.2015.05.12.11.06.29 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 May 2015 11:06:29 -0700 (PDT) Message-ID: <55524124.60708@intel.com> Date: Tue, 12 May 2015 19:06:28 +0100 From: Michael Wood User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: toaster@yoctoproject.org, "Damian, Alexandru" References: In-Reply-To: Subject: Re: [review-request] adamian/20150507_toasterui_fixes X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 May 2015 18:06:35 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Thanks, this fixes a bunch of the url issues for me, I also had to delete the urls.pyc as well as I was getting some strange issues (like where the project links weren't working) Only one issue, what was the reason for doing this?: --- a/bitbake/lib/toaster/toastergui/templates/layerdetails.html +++ b/bitbake/lib/toaster/toastergui/templates/layerdetails.html @@ -37,27 +37,18 @@ document.write("Sorry, An error has occurred loading this page"); console.warn(e); } + + {# If this is not an imported layer then hide the edit ui #} + {% if layerversion.layer_source.sourcetype != layerversion.layer_source.TYPE_IMPORTED %} + $(".icon-pencil").hide(); + $(".delete-current-value").hide(); + $(".icon-trash").hide(); + $(".add-deps").hide(); + {% endif %} + }); -{# If this is not an imported layer then hide the edit ui #} -{% if layerversion.layer_source_id != 3 %} - -{% endif %} - The advantage of doing it in the style/document is that you don't get a visible state change in the page when the page is loaded. e.g. doing this is in the JS will do: All visible -> Hide the .icon-pencil, Hide the .delete-current-value etc all in front of the user. I'd rather have the page state setup correctly at render when possible, if you really want to do this in the JS it needs to be inside the layerDetailsPageInit function and everything hidden by default then shown once the hide/shows inside the page are done. Thanks, Michael On 12/05/15 18:18, Damian, Alexandru wrote: > Hello, > > This is a review request for a single patch that brings all views in > compliance with W3C's HTML5 markup validation service. > > It also fixes minor problems discovered during validation. > > Can you please review ? > > Alex > > -- > Alex Damian > Yocto Project > SSG / OTC > >