All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: Eric Blake <eblake@redhat.com>,
	"Daniel P. Berrange" <berrange@redhat.com>,
	qemu-devel@nongnu.org
Cc: Fam Zheng <famz@redhat.com>, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 5/5] tests: add test case for encrypted qcow2 read/write
Date: Tue, 12 May 2015 15:06:30 -0400	[thread overview]
Message-ID: <55524F36.2010908@redhat.com> (raw)
In-Reply-To: <555247FC.4060009@redhat.com>



On 05/12/2015 02:35 PM, Eric Blake wrote:
> On 05/12/2015 10:09 AM, Daniel P. Berrange wrote:
>> Add a simple test case for qemu-iotests that covers read/write 
>> with encrypted qcow2 files.
>> 
>> Signed-off-by: Daniel P. Berrange <berrange@redhat.com> --- 
>> tests/qemu-iotests/131     | 69
>> ++++++++++++++++++++++++++++++++++++++++++++++ 
>> tests/qemu-iotests/131.out | 46 +++++++++++++++++++++++++++++++ 
>> tests/qemu-iotests/group   |  1 + 3 files changed, 116
>> insertions(+) create mode 100755 tests/qemu-iotests/131 create
>> mode 100644 tests/qemu-iotests/131.out
>> 
>> diff --git a/tests/qemu-iotests/131 b/tests/qemu-iotests/131 new
>> file mode 100755 index 0000000..f44b0a0 --- /dev/null +++
>> b/tests/qemu-iotests/131 @@ -0,0 +1,69 @@ +#!/bin/bash +# +# Test
>> encrypted read/write using plain bdrv_read/bdrv_write +# +#
>> Copyright (C) 2009 Red Hat, Inc.
> 
> Copy-and-paste strikes again; welcome to 2015.  With that fixed, 
> Reviewed-by: Eric Blake <eblake@redhat.com>
> 

Fam Zheng already has a patch on-list that uses test 131, and I think
his patch was submitted first.

(Unless we want to play the "Who gets merged first?" game.)

--js

  reply	other threads:[~2015-05-12 19:06 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-12 16:09 [Qemu-devel] [PATCH 0/5] Misc fixes and testing of qcow[2] encryption Daniel P. Berrange
2015-05-12 16:09 ` [Qemu-devel] [PATCH 1/5] qcow2/qcow: protect against uninitialized encryption key Daniel P. Berrange
2015-05-12 18:06   ` Eric Blake
2015-05-12 16:09 ` [Qemu-devel] [PATCH 2/5] util: move read_password method out of qemu-img into osdep/oslib Daniel P. Berrange
2015-05-12 18:22   ` Eric Blake
2015-05-12 16:09 ` [Qemu-devel] [PATCH 3/5] util: allow \n to terminate password input Daniel P. Berrange
2015-05-12 18:23   ` Eric Blake
2015-05-12 16:09 ` [Qemu-devel] [PATCH 4/5] qemu-io: prompt for encryption keys when required Daniel P. Berrange
2015-05-12 18:32   ` Eric Blake
2015-05-13  8:09     ` Daniel P. Berrange
2015-05-13 10:50       ` Markus Armbruster
2015-05-12 16:09 ` [Qemu-devel] [PATCH 5/5] tests: add test case for encrypted qcow2 read/write Daniel P. Berrange
2015-05-12 18:35   ` Eric Blake
2015-05-12 19:06     ` John Snow [this message]
2015-05-12 19:52       ` [Qemu-devel] [Qemu-block] " Eric Blake
2015-05-12 19:54         ` John Snow
2015-05-18 15:38 ` [Qemu-devel] [PATCH 0/5] Misc fixes and testing of qcow[2] encryption Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55524F36.2010908@redhat.com \
    --to=jsnow@redhat.com \
    --cc=berrange@redhat.com \
    --cc=eblake@redhat.com \
    --cc=famz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.