All of lore.kernel.org
 help / color / mirror / Atom feed
From: Romain Naour <romain.naour@openwide.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] google-breakpad: add patch to fix AArch64 build issue
Date: Wed, 13 May 2015 00:06:54 +0200	[thread overview]
Message-ID: <5552797E.1080106@openwide.fr> (raw)
In-Reply-To: <1431467285-28262-1-git-send-email-thomas.petazzoni@free-electrons.com>

Hi Thomas,

Le 12/05/2015 23:48, Thomas Petazzoni a ?crit :
> Fixes:
> 
>   http://autobuild.buildroot.org/results/b2b/b2bfbcc922b3041ab3a1892d5c1469ec68476682/
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
>  .../0001-add-missing-asm-ptrace-include.patch      | 31 ++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
>  create mode 100644 package/google-breakpad/0001-add-missing-asm-ptrace-include.patch
> 
> diff --git a/package/google-breakpad/0001-add-missing-asm-ptrace-include.patch b/package/google-breakpad/0001-add-missing-asm-ptrace-include.patch
> new file mode 100644
> index 0000000..30e6160
> --- /dev/null
> +++ b/package/google-breakpad/0001-add-missing-asm-ptrace-include.patch
> @@ -0,0 +1,31 @@
> +Include <asm/ptrace.h> to get necessary definitions on AArch64
> +
> +In glibc commit
> +https://sourceware.org/git/?p=glibc.git;a=commit;h=7d05a8168b45c0580e1f9a79c2dd26c8f0d31fca,
> +including <asm/ptrace.h> from <sys/user.h> on AArch64 has been
> +removed. So the Google Breakpad code, which used to build fine on
> +glibc 2.18 (CodeSourcery toolchain for example), no longer builds wiht

with

> +glibc 2.19 (Linaro toolchain for example).
> +
> +To fix this, this patch adds the missing <asm/ptrace.h> include (for
> +AArch64 only, to be conservative).
> +
> +This patch has not been submitted upstream, since more recent versions
> +of Google Breakpad have completely changed this part of the code.
> +
> +Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Build tested with Linaro and Code Sourcery toolchains.
Reviewed-by: Romain Naour <romain.naour@openwide.fr>
Tested-by: Romain Naour <romain.naour@openwide.fr>

Best regards,
Romain
> +
> +Index: b/src/client/linux/minidump_writer/linux_dumper.h
> +===================================================================
> +--- a/src/client/linux/minidump_writer/linux_dumper.h
> ++++ b/src/client/linux/minidump_writer/linux_dumper.h
> +@@ -43,6 +43,9 @@
> + #include <stdint.h>
> + #include <sys/types.h>
> + #include <sys/user.h>
> ++#if defined(__aarch64__)
> ++#include <asm/ptrace.h>
> ++#endif
> + 
> + #include "common/memory.h"
> + #include "google_breakpad/common/minidump_format.h"
> 

  reply	other threads:[~2015-05-12 22:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-12 21:48 [Buildroot] [PATCH] google-breakpad: add patch to fix AArch64 build issue Thomas Petazzoni
2015-05-12 22:06 ` Romain Naour [this message]
2015-05-13  8:07 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5552797E.1080106@openwide.fr \
    --to=romain.naour@openwide.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.