From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 00/19] Move PMDs to drivers directory Date: Wed, 13 May 2015 15:33:27 +0200 Message-ID: <555352A7.6090408@6wind.com> References: <1431012951-6423-1-git-send-email-bruce.richardson@intel.com> <1431450315-13179-1-git-send-email-bruce.richardson@intel.com> <555254E5.7050906@6wind.com> <20150513090109.GB12276@bricha3-MOBL3> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Bruce Richardson Return-path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id 7E3CE11C5 for ; Wed, 13 May 2015 15:34:11 +0200 (CEST) Received: by widdi4 with SMTP id di4so198895475wid.0 for ; Wed, 13 May 2015 06:34:11 -0700 (PDT) In-Reply-To: <20150513090109.GB12276@bricha3-MOBL3> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-05-13 11:01, Bruce Richardson: > On Tue, May 12, 2015 at 09:30:45PM +0200, Thomas Monjalon wrote: >> 2015-05-12 19:04, Bruce Richardson: >>> drivers/e1000/e1000/e1000_hw.h | 1026 ++++ >> >> As explained in a previous comment, >> http://dpdk.org/ml/archives/dev/2015-May/017509.html >> I think this path would be better: >> drivers/net/e1000/base/e1000_hw.h > > Two reasons why I didn't create the "net" subfolder: > 1. I initally forgot to consider it :-( > 2. While we may at some future point have other device driver types, are we really > needing to start categorising PMDs at this point? > > As for the base driver part, I was viewing that as a something that should be > a separate patch set, since it's unrelated to moving things to the drivers > subdir. I understand your points and I partially agree. However, file moves may be perturbing because it change habits and may complicate a bit the git history browsing. So I think it's better to minimize such moves and do altogether.