From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <michael.g.wood@intel.com>
Received: by yocto-www.yoctoproject.org (Postfix, from userid 118)
	id 1658DE008DC; Wed, 13 May 2015 07:10:10 -0700 (PDT)
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on
	yocto-www.yoctoproject.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW
	autolearn=ham version=3.3.1
X-Spam-HAM-Report: * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at
	http://www.dnswl.org/, low *      trust
	*      [209.85.212.169 listed in list.dnswl.org]
	* -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
	*      [score: 0.0000]
Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com
	[209.85.212.169])
	by yocto-www.yoctoproject.org (Postfix) with ESMTP id 9CAA1E007CC
	for <toaster@yoctoproject.org>; Wed, 13 May 2015 07:09:59 -0700 (PDT)
Received: by wizk4 with SMTP id k4so200501775wiz.1
	for <toaster@yoctoproject.org>; Wed, 13 May 2015 07:09:59 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20130820;
	h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to
	:cc:subject:references:in-reply-to:content-type
	:content-transfer-encoding;
	bh=RLHsc3NvU6UuhD6tNZB0dAmcg/TcMUkGtaNhSgMoxtE=;
	b=VB7pWjtQNn9irYXee1ol7TytLiGJ+k7CcnNei3mfUsH0rjg8MCBuKB5S6YDX5xilMq
	cqZj6F5O2mpdm3ORPwsLpwFRKED8f9Oa/FbQxNjJWE7PBvmdNihy0CekJmfhIbaXuck1
	8oAu0SQgyUmWX8FUPpqS6aXEtCeg+m83BJwowokwdKXxXQ7tVm9ea/L890rB6mz2BVbi
	XQuh3cPXpjF1RJxBbULU5EIV63dcO6J5xRPKVmb2JpZ3AO9Rnf3cs/i7t4fZrwsIxtJG
	+9t25jaI8izyvjsTF2CzG779hBnRxTYilQ2d/C9bR7f0WRJdUFhpRjSvlf7VyFFmJyZ1
	3U9g==
X-Gm-Message-State: ALoCoQkqRdNVaN7biyhfsElZt9iFtbjcEswM7I7Ujtk2uug5XGulstWcE8tbY3CZV0voZQ0icYmN
X-Received: by 10.180.78.135 with SMTP id b7mr14580780wix.65.1431526198776;
	Wed, 13 May 2015 07:09:58 -0700 (PDT)
Received: from [192.168.2.74] ([83.217.123.106])
	by mx.google.com with ESMTPSA id
	pj5sm27740808wjb.40.2015.05.13.07.09.58
	(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
	Wed, 13 May 2015 07:09:58 -0700 (PDT)
Message-ID: <55535B35.50400@intel.com>
Date: Wed, 13 May 2015 15:09:57 +0100
From: Michael Wood <michael.g.wood@intel.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: "Damian, Alexandru" <alexandru.damian@intel.com>
References: <CAJ2CSBuk6_N72nvw0=_TAn0OqOsQByk0GSsnxfVO3dFTO+28qw@mail.gmail.com>
	<55524124.60708@intel.com>
	<CAJ2CSBtCSW_fDYW62UD-3K0zUhy2TSgYiajSuZDzyD=PtLOsqw@mail.gmail.com>
	<CAJ2CSBvy-gMPk9Vpx__YymQMyRLPAQbYi=2Sa73b_EnP-v6X7A@mail.gmail.com>
In-Reply-To: <CAJ2CSBvy-gMPk9Vpx__YymQMyRLPAQbYi=2Sa73b_EnP-v6X7A@mail.gmail.com>
Cc: "toaster@yoctoproject.org" <toaster@yoctoproject.org>
Subject: Re: [review-request] adamian/20150507_toasterui_fixes
X-BeenThere: toaster@yoctoproject.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: Web based interface for BitBake <toaster.yoctoproject.org>
List-Unsubscribe: <https://lists.yoctoproject.org/options/toaster>,
	<mailto:toaster-request@yoctoproject.org?subject=unsubscribe>
List-Archive: <http://lists.yoctoproject.org/pipermail/toaster>
List-Post: <mailto:toaster@yoctoproject.org>
List-Help: <mailto:toaster-request@yoctoproject.org?subject=help>
List-Subscribe: <https://lists.yoctoproject.org/listinfo/toaster>,
	<mailto:toaster-request@yoctoproject.org?subject=subscribe>
X-List-Received-Date: Wed, 13 May 2015 14:10:10 -0000
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit

Looks good to me.

Thanks,

Michael

On 13/05/15 14:10, Damian, Alexandru wrote:
> I found a solution using <style> and scoped.
>
> Can you please review on the same branch ?
>
> Cheers,
> Alex
>
> On Wed, May 13, 2015 at 10:42 AM, Damian, Alexandru 
> <alexandru.damian@intel.com <mailto:alexandru.damian@intel.com>> wrote:
>
>
>
>     On Tue, May 12, 2015 at 7:06 PM, Michael Wood
>     <michael.g.wood@intel.com <mailto:michael.g.wood@intel.com>> wrote:
>
>
>         Thanks, this fixes a bunch of the url issues for me, I also
>         had to delete the urls.pyc as well as I was getting some
>         strange issues (like where the project links weren't working)
>
>         Only one issue, what was the reason for doing this?:
>
>
>         --- a/bitbake/lib/toaster/toastergui/templates/layerdetails.html
>         +++ b/bitbake/lib/toaster/toastergui/templates/layerdetails.html
>         @@ -37,27 +37,18 @@
>                document.write("Sorry, An error has occurred loading
>         this page");
>                console.warn(e);
>              }
>         +
>         +    {# If this is not an imported layer then hide the edit ui #}
>         +    {% if layerversion.layer_source.sourcetype !=
>         layerversion.layer_source.TYPE_IMPORTED %}
>         +    $(".icon-pencil").hide();
>         +    $(".delete-current-value").hide();
>         +    $(".icon-trash").hide();
>         +    $(".add-deps").hide();
>         +    {% endif %}
>         +
>            });
>          </script>
>
>         -{# If this is not an imported layer then hide the edit ui #}
>         -{% if layerversion.layer_source_id != 3 %}
>         -<style>
>         - .icon-pencil {
>         -   display:none;
>         - }
>         -.delete-current-value{
>         -  display: none;
>         -}
>         - li .icon-trash {
>         -   display:none;
>         - }
>         - .add-deps {
>         -   display:none;
>         - }
>         -</style>
>         -{% endif %}
>         -
>
>         The advantage of doing it in the style/document is that you
>         don't get a visible state change in the page when the page is
>         loaded.
>         e.g. doing this is in the JS will do: All visible ->  Hide the
>         .icon-pencil, Hide the .delete-current-value etc all in front
>         of the user.
>
>
>     ​ Unfortunately, the <style> tag can only occur ​in certain places
>     under HTML5 specification; the validator complains about its
>     presence there. I think the presence there leads to undefined
>     behaviour in the specification, and it's not guaranteed to work in
>     future browsers.
>
>
>         I'd rather have the page state setup correctly at render when
>         possible, if you really want to do this in the JS it needs to
>         be inside the
>         ​ ​
>         layerDetailsPageInit function and everything hidden by default
>         then shown once the hide/shows inside the page are done.
>
>
>     Yep, this would be a better solution. I'm going to push a patch on
>     top of this one to reverse the behaviour.
>
>     ​
>
>
>         Thanks,
>
>         Michael
>
>
>         On 12/05/15 18:18, Damian, Alexandru wrote:
>
>             Hello,
>
>             This is a review request for a single patch that brings
>             all views in compliance with W3C's HTML5 markup validation
>             service.
>
>             It also fixes minor problems discovered during validation.
>
>             Can you please review ?
>
>             Alex
>
>             -- 
>             Alex Damian
>             Yocto Project
>             SSG / OTC
>
>
>
>         ---------------------------------------------------------------------
>         Intel Corporation (UK) Limited
>         Registered No. 1134945 (England)
>         Registered Office: Pipers Way, Swindon SN3 1RJ
>         VAT No: 860 2173 47
>
>         This e-mail and any attachments may contain confidential
>         material for
>         the sole use of the intended recipient(s). Any review or
>         distribution
>         by others is strictly prohibited. If you are not the intended
>         recipient, please contact the sender and delete all copies.
>
>
>
>
>     -- 
>     Alex Damian
>     Yocto Project
>     SSG / OTC
>
>
>
>
> -- 
> Alex Damian
> Yocto Project
> SSG / OTC
>
> ---------------------------------------------------------------------
> Intel Corporation (UK) Limited
> Registered No. 1134945 (England)
> Registered Office: Pipers Way, Swindon SN3 1RJ
> VAT No: 860 2173 47
>
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
>