From: Paolo Bonzini <pbonzini@redhat.com>
To: Claudio Fontana <claudio.fontana@huawei.com>,
Luiz Capitulino <lcapitulino@redhat.com>,
hw.claudio@gmail.com
Cc: Peter Maydell <peter.maydell@linaro.org>,
Gonglei <arei.gonglei@huawei.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC v4] monitor: add memory search commands s, sp
Date: Wed, 13 May 2015 17:19:41 +0200 [thread overview]
Message-ID: <55536B8D.8090303@redhat.com> (raw)
In-Reply-To: <55521640.6010101@huawei.com>
On 12/05/2015 17:03, Claudio Fontana wrote:
> I see, will take some time to figure out I think, due to my lack of familiarity with the Windows compilation environment.
>
> Incidentally, if somebody knows of memmem equivalents in the Windows API, or how function replacements are usually handled, please let me know.
>
> I guess we could add a replacement function in util/ to compile #ifdef _WIN32?
Yes, you can use $(CONFIG_WIN32) in util/Makefile.objs. It doesn't have
to be fancy, a simple O(n^2) search would do.
Later we could use Boyer-Moore or some other optimization.
> Basically it would be a duplicate of the work already done in gnulib...
Yes. The good thing is that it would be easy to test without a
cross-compiler, since symbols in an executable override symbols in glibc.
> are all other supported targets ok with using the GNU function memmem of string.h ?
Until they complain, they are...
Paolo
prev parent reply other threads:[~2015-05-13 15:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-24 12:39 [Qemu-devel] [RFC v4] monitor: add memory search commands s, sp hw.claudio
2015-05-01 17:15 ` Luiz Capitulino
2015-05-11 14:16 ` Luiz Capitulino
2015-05-12 15:03 ` Claudio Fontana
2015-05-13 15:19 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55536B8D.8090303@redhat.com \
--to=pbonzini@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=claudio.fontana@huawei.com \
--cc=hw.claudio@gmail.com \
--cc=lcapitulino@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.