All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@arm.com>
To: Rob Herring <robherring2@gmail.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"grant.likely@linaro.org" <grant.likely@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] of: base: upgrade initcall level of of_init from core to pure
Date: Wed, 13 May 2015 17:54:16 +0100	[thread overview]
Message-ID: <555381B8.5020504@arm.com> (raw)
In-Reply-To: <CAL_JsqK6cZ+rYiox0=EE5wjwtk6T8edCzDG0=uj2ZdK-QHoX3g@mail.gmail.com>



On 13/05/15 17:34, Rob Herring wrote:
> On Wed, May 13, 2015 at 9:50 AM, Sudeep Holla <sudeep.holla@arm.com> wrote:
>> On 13/05/15 14:46, Rob Herring wrote:
>>> On Wed, May 13, 2015 at 5:03 AM, Sudeep Holla <sudeep.holla@arm.com>
>>> wrote:
>
> [...]
>
>>>> Yes I read and was bit hesitant initially to do this change, but found
>>>> no better way. I posted mainly to discuss other possibilities to solve
>>>> the issue.
>>>
>>>
>>> Perhaps of_init should not be an initcall at all and it should go into
>>> driver_init().
>>
>>
>> That seems ideal place to me as most of kset and kobjects are created
>> there. Something like below patch ? However found that PPC had a
>> function with same name which can conflict and we need to rename one of
>> these two.
>
> It looks like the PPC one is in the boot wrapper. They shouldn't
> collide. If they do, then how about of_core_init.
>

Thanks for the review, will check the PPC build and change accordingly
if required.

Regards,
Sudeep

      reply	other threads:[~2015-05-13 16:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-12 17:38 [PATCH] of: base: upgrade initcall level of of_init from core to pure Sudeep Holla
2015-05-12 17:38 ` Sudeep Holla
     [not found] ` <1431452282-10207-1-git-send-email-sudeep.holla-5wv7dgnIgG8@public.gmane.org>
2015-05-12 22:55   ` Rob Herring
2015-05-12 22:55     ` Rob Herring
2015-05-13 10:03     ` Sudeep Holla
2015-05-13 13:46       ` Rob Herring
2015-05-13 14:50         ` Sudeep Holla
     [not found]           ` <555364AA.7030703-5wv7dgnIgG8@public.gmane.org>
2015-05-13 16:34             ` Rob Herring
2015-05-13 16:34               ` Rob Herring
2015-05-13 16:54               ` Sudeep Holla [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=555381B8.5020504@arm.com \
    --to=sudeep.holla@arm.com \
    --cc=benh@kernel.crashing.org \
    --cc=devicetree@vger.kernel.org \
    --cc=grant.likely@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=robherring2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.