From: Alexei Starovoitov <ast@plumgrid.com>
To: Jesper Dangaard Brouer <brouer@redhat.com>,
Daniel Borkmann <borkmann@iogearbox.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Ben Hutchings <ben@decadent.org.uk>,
Robert Olsson <robert@herjulf.net>,
Ben Greear <greearb@candelatech.com>
Subject: Re: pktgen scripts
Date: Wed, 13 May 2015 10:14:13 -0700 [thread overview]
Message-ID: <55538665.4020201@plumgrid.com> (raw)
In-Reply-To: <20150513150237.0abf3628@redhat.com>
On 5/13/15 6:02 AM, Jesper Dangaard Brouer wrote:
> Hi Alexei,
>
> I've cleaned up my pktgen scripts[1]. Do you think we should add them
> instead of the sample scripts in "samples/pktgen/pktgen.conf-*" ?
+1
> The main difference is I'm replacing the "pgset" with functions not
> needing global variable $PGDEV. Three new functions reflect pktgen's
> different components:
> * pg_ctrl() control "pgctrl" (/proc/net/pktgen/pgctrl)
> * pg_thread() control the kernel threads and binding to devices
> * pg_set() control setup of individual devices
>
> I've named the sample scripts: "pktgen_sample{01,02,03}_desc.sh" in-order
> to suggest a reading order.
> I've also added a script named: "pktgen_bench_xmit_mode_netif_receive.sh"
> which is basically your ingress benchmarking script.
>
> [1] https://github.com/netoptimizer/network-testing/tree/master/pktgen
Looks great!! Much better than old samples/pktgen/.
Could you add a readme file as well with few command line examples?
It wasn't obvious how '-b' and other flags are working. I guess if
somebody just tries to run them, the 'usage' function will explain
things too.
prev parent reply other threads:[~2015-05-13 17:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 13:02 pktgen scripts Jesper Dangaard Brouer
2015-05-13 17:14 ` Alexei Starovoitov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55538665.4020201@plumgrid.com \
--to=ast@plumgrid.com \
--cc=ben@decadent.org.uk \
--cc=borkmann@iogearbox.net \
--cc=brouer@redhat.com \
--cc=greearb@candelatech.com \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=robert@herjulf.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.