All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Borkmann <daniel@iogearbox.net>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: davem@davemloft.net, fw@strlen.de, ast@plumgrid.com,
	jhs@mojatatu.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: core: set and refine qdisc pkt len before tc_classify
Date: Wed, 13 May 2015 23:36:49 +0200	[thread overview]
Message-ID: <5553C3F1.4070208@iogearbox.net> (raw)
In-Reply-To: <1431552055.27831.17.camel@edumazet-glaptop2.roam.corp.google.com>

On 05/13/2015 11:20 PM, Eric Dumazet wrote:
...
> Is qdisc_pkt_len_init() still inlined, now it has 2 callers ?
>
> People using policers on ingress are very often disabling GRO for
> various historical reasons.

Yes, tested policer and for getting it working on my side, GRO needs
to be off.

> Since handle_ing() is very uncommon, I would prefer not slowing down tx
> just so that GRO ~5% error in ingress is fixed.

I see a callq dc0 <qdisc_pkt_len_init> now. Ok, in that case Florian's
original version is fine:

   http://patchwork.ozlabs.org/patch/471346/

> I noticed you did not CC me, don't be afraid to include me next time one
> of my commit is referred in a changelog ;)

Hmm, I did Cc you. ;)

To:	davem@davemloft.net
Cc:	fw@strlen.de, ast@plumgrid.com, jhs@mojatatu.com,
	eric.dumazet@gmail.com, netdev@vger.kernel.org,
	daniel@iogearbox.net

Thanks,
Daniel

  parent reply	other threads:[~2015-05-13 21:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-13 20:50 [PATCH net-next v2] net: core: set and refine qdisc pkt len before tc_classify Daniel Borkmann
2015-05-13 21:07 ` Alexei Starovoitov
2015-05-13 21:20 ` Eric Dumazet
2015-05-13 21:33   ` Florian Westphal
2015-05-13 21:38     ` Eric Dumazet
2015-05-13 22:27       ` Alexei Starovoitov
2015-05-13 22:43         ` Eric Dumazet
2015-05-13 21:36   ` Daniel Borkmann [this message]
2015-05-13 21:42   ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5553C3F1.4070208@iogearbox.net \
    --to=daniel@iogearbox.net \
    --cc=ast@plumgrid.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=fw@strlen.de \
    --cc=jhs@mojatatu.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.