All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shuah Khan <shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
To: Darren Hart <dvhart-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	Linux Kernel Mailing List
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Cc: linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Ingo Molnar <mingo-X9Un+BFzKDI@public.gmane.org>,
	Peter Zijlstra <peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
	Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
	Davidlohr Bueso <dave-h16yJtLeMjHk1uMJSBkQmQ@public.gmane.org>,
	KOSAKI Motohiro
	<kosaki.motohiro-+CUm20s59erQFUHtdCDX3A@public.gmane.org>,
	chrubis-AlSwsSmVLrQ@public.gmane.org,
	Shuah Khan <shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
Subject: Re: [PATCH v4 0/6] selftests: Add futex functional tests
Date: Wed, 13 May 2015 17:22:22 -0600	[thread overview]
Message-ID: <5553DCAE.2010208@osg.samsung.com> (raw)
In-Reply-To: <cover.1431489408.git.dvhart-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>

On 05/12/2015 10:07 PM, Darren Hart wrote:
> Hi Shuah,
> 
> This series begins the process of migrating my futextest tests into kselftest.
> I've started with only the functional tests, as the performance and stress may
> not be appropriate for kselftest as they stand.
> 
> I cleaned up various complaints from checkpatch, but I ignored others that would
> require significant rework of the testcases, such as not using volatile and not
> creating new typedefs.
> 

Daren,

This patch series is good. kselftest run and install
are good. I see the following results. Something you
would expect?? No Issues and I am going to get them
into 4.2 - should show up in linux-kselftest next.

Thanks for adding these.

thanks,
-- Shuah

futex_requeue_pi: Test requeue functionality
	Arguments: broadcast=0 locked=0 owner=0 timeout=0ns
	ERROR: Operation not permitted: pthread_create
	ERROR: Creating waiting thread failed
Result: ERROR
futex_requeue_pi: Test requeue functionality
	Arguments: broadcast=1 locked=0 owner=0 timeout=0ns
	ERROR: Operation not permitted: pthread_create
	ERROR: Creating waiting thread failed
Result: ERROR
futex_requeue_pi: Test requeue functionality
	Arguments: broadcast=1 locked=1 owner=0 timeout=0ns
	ERROR: Operation not permitted: pthread_create
	ERROR: Creating waiting thread failed
Result: ERROR
futex_requeue_pi: Test requeue functionality
	Arguments: broadcast=1 locked=0 owner=1 timeout=0ns
	ERROR: Operation not permitted: pthread_create
	ERROR: Creating third party blocker thread failed
Result: ERROR
futex_requeue_pi: Test requeue functionality
	Arguments: broadcast=0 locked=1 owner=0 timeout=0ns
	ERROR: Operation not permitted: pthread_create
	ERROR: Creating waiting thread failed
Result: ERROR
futex_requeue_pi: Test requeue functionality
	Arguments: broadcast=0 locked=0 owner=1 timeout=0ns
	ERROR: Operation not permitted: pthread_create
	ERROR: Creating third party blocker thread failed
Result: ERROR
futex_requeue_pi: Test requeue functionality
	Arguments: broadcast=1 locked=1 owner=0 timeout=5000ns
	ERROR: Operation not permitted: pthread_create
	ERROR: Creating waiting thread failed
Result: ERROR
futex_requeue_pi: Test requeue functionality
	Arguments: broadcast=0 locked=1 owner=0 timeout=5000ns
	ERROR: Operation not permitted: pthread_create
	ERROR: Creating waiting thread failed
Result: ERROR
futex_requeue_pi: Test requeue functionality
	Arguments: broadcast=1 locked=1 owner=0 timeout=500000ns
	ERROR: Operation not permitted: pthread_create
	ERROR: Creating waiting thread failed
Result: ERROR
futex_requeue_pi: Test requeue functionality
	Arguments: broadcast=0 locked=1 owner=0 timeout=500000ns
	ERROR: Operation not permitted: pthread_create
	ERROR: Creating waiting thread failed
Result: ERROR
futex_requeue_pi: Test requeue functionality
	Arguments: broadcast=1 locked=0 owner=0 timeout=5000ns
	ERROR: Operation not permitted: pthread_create
	ERROR: Creating waiting thread failed
Result: ERROR
futex_requeue_pi: Test requeue functionality
	Arguments: broadcast=0 locked=0 owner=0 timeout=5000ns
	ERROR: Operation not permitted: pthread_create
	ERROR: Creating waiting thread failed
Result: ERROR
futex_requeue_pi: Test requeue functionality
	Arguments: broadcast=1 locked=0 owner=0 timeout=500000ns
	ERROR: Operation not permitted: pthread_create
	ERROR: Creating waiting thread failed
Result: ERROR
futex_requeue_pi: Test requeue functionality
	Arguments: broadcast=0 locked=0 owner=0 timeout=500000ns
	ERROR: Operation not permitted: pthread_create
	ERROR: Creating waiting thread failed
Result: ERROR
futex_requeue_pi: Test requeue functionality
	Arguments: broadcast=1 locked=0 owner=1 timeout=5000ns
	ERROR: Operation not permitted: pthread_create
	ERROR: Creating third party blocker thread failed
Result: ERROR
futex_requeue_pi: Test requeue functionality
	Arguments: broadcast=0 locked=1 owner=0 timeout=5000ns
	ERROR: Operation not permitted: pthread_create
	ERROR: Creating waiting thread failed
Result: ERROR
futex_requeue_pi: Test requeue functionality
	Arguments: broadcast=1 locked=0 owner=1 timeout=500000ns
	ERROR: Operation not permitted: pthread_create
	ERROR: Creating third party blocker thread failed
Result: ERROR
futex_requeue_pi: Test requeue functionality
	Arguments: broadcast=0 locked=1 owner=0 timeout=500000ns
	ERROR: Operation not permitted: pthread_create
	ERROR: Creating waiting thread failed
Result: ERROR
futex_requeue_pi: Test requeue functionality
	Arguments: broadcast=1 locked=1 owner=0 timeout=2000000000ns
	ERROR: Operation not permitted: pthread_create
	ERROR: Creating waiting thread failed
Result: ERROR
futex_requeue_pi: Test requeue functionality
	Arguments: broadcast=0 locked=1 owner=0 timeout=2000000000ns
	ERROR: Operation not permitted: pthread_create
	ERROR: Creating waiting thread failed
Result: ERROR

futex_requeue_pi_mismatched_ops: Detect mismatched requeue_pi operations
Result:  PASS

futex_requeue_pi_signal_restart: Test signal handling during requeue_pi
	Arguments: <none>
	ERROR: Operation not permitted: pthread_create
	ERROR: Unknown error -1: Creating waiting thread failedResult: ERROR

futex_wait_timeout: Block on a futex and wait for timeout
	Arguments: timeout=100000ns
Result:  PASS

futex_wait_wouldblock: Test the unexpected futex value in FUTEX_WAIT
Result:  PASS

futex_wait_uninitialized_heap: Test the uninitialized futex value in
FUTEX_WAIT
Result:  PASS
futex_wait_private_mapped_file: Test the futex value of private file
mappings in FUTEX_WAIT
Result:  PASS


-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org | (970) 217-8978

WARNING: multiple messages have this Message-ID (diff)
From: Shuah Khan <shuahkh@osg.samsung.com>
To: Darren Hart <dvhart@linux.intel.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: linux-api@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Davidlohr Bueso <dave@stgolabs.net>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	chrubis@suse.cz, Shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: [PATCH v4 0/6] selftests: Add futex functional tests
Date: Wed, 13 May 2015 17:22:22 -0600	[thread overview]
Message-ID: <5553DCAE.2010208@osg.samsung.com> (raw)
In-Reply-To: <cover.1431489408.git.dvhart@linux.intel.com>

On 05/12/2015 10:07 PM, Darren Hart wrote:
> Hi Shuah,
> 
> This series begins the process of migrating my futextest tests into kselftest.
> I've started with only the functional tests, as the performance and stress may
> not be appropriate for kselftest as they stand.
> 
> I cleaned up various complaints from checkpatch, but I ignored others that would
> require significant rework of the testcases, such as not using volatile and not
> creating new typedefs.
> 

Daren,

This patch series is good. kselftest run and install
are good. I see the following results. Something you
would expect?? No Issues and I am going to get them
into 4.2 - should show up in linux-kselftest next.

Thanks for adding these.

thanks,
-- Shuah

futex_requeue_pi: Test requeue functionality
	Arguments: broadcast=0 locked=0 owner=0 timeout=0ns
	ERROR: Operation not permitted: pthread_create
	ERROR: Creating waiting thread failed
Result: ERROR
futex_requeue_pi: Test requeue functionality
	Arguments: broadcast=1 locked=0 owner=0 timeout=0ns
	ERROR: Operation not permitted: pthread_create
	ERROR: Creating waiting thread failed
Result: ERROR
futex_requeue_pi: Test requeue functionality
	Arguments: broadcast=1 locked=1 owner=0 timeout=0ns
	ERROR: Operation not permitted: pthread_create
	ERROR: Creating waiting thread failed
Result: ERROR
futex_requeue_pi: Test requeue functionality
	Arguments: broadcast=1 locked=0 owner=1 timeout=0ns
	ERROR: Operation not permitted: pthread_create
	ERROR: Creating third party blocker thread failed
Result: ERROR
futex_requeue_pi: Test requeue functionality
	Arguments: broadcast=0 locked=1 owner=0 timeout=0ns
	ERROR: Operation not permitted: pthread_create
	ERROR: Creating waiting thread failed
Result: ERROR
futex_requeue_pi: Test requeue functionality
	Arguments: broadcast=0 locked=0 owner=1 timeout=0ns
	ERROR: Operation not permitted: pthread_create
	ERROR: Creating third party blocker thread failed
Result: ERROR
futex_requeue_pi: Test requeue functionality
	Arguments: broadcast=1 locked=1 owner=0 timeout=5000ns
	ERROR: Operation not permitted: pthread_create
	ERROR: Creating waiting thread failed
Result: ERROR
futex_requeue_pi: Test requeue functionality
	Arguments: broadcast=0 locked=1 owner=0 timeout=5000ns
	ERROR: Operation not permitted: pthread_create
	ERROR: Creating waiting thread failed
Result: ERROR
futex_requeue_pi: Test requeue functionality
	Arguments: broadcast=1 locked=1 owner=0 timeout=500000ns
	ERROR: Operation not permitted: pthread_create
	ERROR: Creating waiting thread failed
Result: ERROR
futex_requeue_pi: Test requeue functionality
	Arguments: broadcast=0 locked=1 owner=0 timeout=500000ns
	ERROR: Operation not permitted: pthread_create
	ERROR: Creating waiting thread failed
Result: ERROR
futex_requeue_pi: Test requeue functionality
	Arguments: broadcast=1 locked=0 owner=0 timeout=5000ns
	ERROR: Operation not permitted: pthread_create
	ERROR: Creating waiting thread failed
Result: ERROR
futex_requeue_pi: Test requeue functionality
	Arguments: broadcast=0 locked=0 owner=0 timeout=5000ns
	ERROR: Operation not permitted: pthread_create
	ERROR: Creating waiting thread failed
Result: ERROR
futex_requeue_pi: Test requeue functionality
	Arguments: broadcast=1 locked=0 owner=0 timeout=500000ns
	ERROR: Operation not permitted: pthread_create
	ERROR: Creating waiting thread failed
Result: ERROR
futex_requeue_pi: Test requeue functionality
	Arguments: broadcast=0 locked=0 owner=0 timeout=500000ns
	ERROR: Operation not permitted: pthread_create
	ERROR: Creating waiting thread failed
Result: ERROR
futex_requeue_pi: Test requeue functionality
	Arguments: broadcast=1 locked=0 owner=1 timeout=5000ns
	ERROR: Operation not permitted: pthread_create
	ERROR: Creating third party blocker thread failed
Result: ERROR
futex_requeue_pi: Test requeue functionality
	Arguments: broadcast=0 locked=1 owner=0 timeout=5000ns
	ERROR: Operation not permitted: pthread_create
	ERROR: Creating waiting thread failed
Result: ERROR
futex_requeue_pi: Test requeue functionality
	Arguments: broadcast=1 locked=0 owner=1 timeout=500000ns
	ERROR: Operation not permitted: pthread_create
	ERROR: Creating third party blocker thread failed
Result: ERROR
futex_requeue_pi: Test requeue functionality
	Arguments: broadcast=0 locked=1 owner=0 timeout=500000ns
	ERROR: Operation not permitted: pthread_create
	ERROR: Creating waiting thread failed
Result: ERROR
futex_requeue_pi: Test requeue functionality
	Arguments: broadcast=1 locked=1 owner=0 timeout=2000000000ns
	ERROR: Operation not permitted: pthread_create
	ERROR: Creating waiting thread failed
Result: ERROR
futex_requeue_pi: Test requeue functionality
	Arguments: broadcast=0 locked=1 owner=0 timeout=2000000000ns
	ERROR: Operation not permitted: pthread_create
	ERROR: Creating waiting thread failed
Result: ERROR

futex_requeue_pi_mismatched_ops: Detect mismatched requeue_pi operations
Result:  PASS

futex_requeue_pi_signal_restart: Test signal handling during requeue_pi
	Arguments: <none>
	ERROR: Operation not permitted: pthread_create
	ERROR: Unknown error -1: Creating waiting thread failedResult: ERROR

futex_wait_timeout: Block on a futex and wait for timeout
	Arguments: timeout=100000ns
Result:  PASS

futex_wait_wouldblock: Test the unexpected futex value in FUTEX_WAIT
Result:  PASS

futex_wait_uninitialized_heap: Test the uninitialized futex value in
FUTEX_WAIT
Result:  PASS
futex_wait_private_mapped_file: Test the futex value of private file
mappings in FUTEX_WAIT
Result:  PASS


-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978

  parent reply	other threads:[~2015-05-13 23:22 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-13  4:07 [PATCH v4 0/6] selftests: Add futex functional tests Darren Hart
2015-05-13  4:07 ` Darren Hart
2015-05-13  4:07 ` [PATCH 3/6] selftests/futex: Increment ksft pass and fail counters Darren Hart
2015-05-13  4:07 ` [PATCH 4/6] selftests: Add futex tests to the top-level Makefile Darren Hart
2015-05-13  4:07 ` [PATCH 5/6] kselftest: Add exit code defines Darren Hart
2015-05-13  4:07 ` [PATCH 6/6] selftests/futex: Add .gitignore Darren Hart
     [not found] ` <cover.1431489408.git.dvhart-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-05-13  4:07   ` [PATCH 1/6] selftests: Add futex functional tests Darren Hart
2015-05-13  4:07     ` Darren Hart
2015-05-13  4:07   ` [PATCH 2/6] selftests/futex: Update Makefile to use lib.mk Darren Hart
2015-05-13  4:07     ` Darren Hart
2015-05-13 23:22   ` Shuah Khan [this message]
2015-05-13 23:22     ` [PATCH v4 0/6] selftests: Add futex functional tests Shuah Khan
     [not found]     ` <5553DCAE.2010208-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2015-05-13 23:34       ` Darren Hart
2015-05-13 23:34         ` Darren Hart
     [not found]         ` <D1792C54.CCE05%dvhart-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-05-14  0:40           ` Shuah Khan
2015-05-14  0:40             ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5553DCAE.2010208@osg.samsung.com \
    --to=shuahkh-jph+aebz4p+uejcrhfaqsw@public.gmane.org \
    --cc=chrubis-AlSwsSmVLrQ@public.gmane.org \
    --cc=dave-h16yJtLeMjHk1uMJSBkQmQ@public.gmane.org \
    --cc=dvhart-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=kosaki.motohiro-+CUm20s59erQFUHtdCDX3A@public.gmane.org \
    --cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mingo-X9Un+BFzKDI@public.gmane.org \
    --cc=peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.