From: "Kim, Milo" <milo.kim@ti.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] backlight/lp855x: Don't clear level on suspend/blank
Date: Wed, 13 May 2015 23:31:29 +0000 [thread overview]
Message-ID: <5553DED1.1050800@ti.com> (raw)
In-Reply-To: <1431376325-25741-1-git-send-email-seanpaul@chromium.org>
Hi Sean,
On 5/14/2015 4:33 AM, Sean Paul wrote:
>
>
> On Mon, May 11, 2015 at 3:48 PM, Kim, Milo <milo.kim@ti.com
> <mailto:milo.kim@ti.com>> wrote:
>
> Hi Sean,
>
> On 5/12/2015 5:32 AM, Sean Paul wrote:
>
> Don't clear the backlight level when we're going into suspend or
> blanking. Instead, just temporarily set the level to 0 so we retain
> the value when we resume.
>
>
> Could you describe what the problem is? I wrote same code in other
> backlight drivers. So maybe I need to look into them as well.
>
>
> Hi Milo,
> Well, I'm not sure what the expected behavior is, but our userspace
> expects the driver to maintain its brightness across suspend/resume. The
> way things are coded now, the driver will clear the brightness value on
> suspend such that when we resume, the backlight is restored to 0.
Got it. Your patch makes sense. Thanks for catching this.
Best regards,
Milo
next prev parent reply other threads:[~2015-05-13 23:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 20:32 [PATCH] backlight/lp855x: Don't clear level on suspend/blank Sean Paul
2015-05-11 22:48 ` Kim, Milo
2015-05-13 23:31 ` Kim, Milo [this message]
2015-05-13 23:32 ` Kim, Milo
2015-05-13 23:40 ` Benson Leung
2015-05-14 7:25 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5553DED1.1050800@ti.com \
--to=milo.kim@ti.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.