Re: [PATCH v4 0/6] selftests: Add futex functional tests

[Shuah Khan <shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>]

On 05/13/2015 05:34 PM, Darren Hart wrote:
> On 5/13/15, 4:22 PM, "Shuah Khan" <shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> wrote:
> 
>> On 05/12/2015 10:07 PM, Darren Hart wrote:
>>> Hi Shuah,
>>>
>>> This series begins the process of migrating my futextest tests into
>>> kselftest.
>>> I've started with only the functional tests, as the performance and
>>> stress may
>>> not be appropriate for kselftest as they stand.
>>>
>>> I cleaned up various complaints from checkpatch, but I ignored others
>>> that would
>>> require significant rework of the testcases, such as not using volatile
>>> and not
>>> creating new typedefs.
>>>
>>
>> Daren,
>>
>> This patch series is good. kselftest run and install
>> are good. I see the following results. Something you
>> would expect??
> 
> Yes, that is all expected behavior if you don't run as root and your user
> doesn't have the necessary capabilities added -  similar to other tests
> with privileged operations.
> 
>> No Issues and I am going to get them
>> into 4.2 - should show up in linux-kselftest next.
> 
> Great, thanks. Perhaps some explicit capabilities tests and clearer error
> messages would make sense as a follow-on patch.
> 
> Thanks for working with me to get these into the kernel, I think it will
> improve futex test exposure and hopefully encourage people to write more
> tests to fill some of the gaps.
> 

Applied to linux-kselftest next for 4.2

thanks,
-- Shuah


-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org | (970) 217-8978