From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shuah Khan Subject: Re: [PATCH v4 0/6] selftests: Add futex functional tests Date: Wed, 13 May 2015 18:40:32 -0600 Message-ID: <5553EF00.8080406@osg.samsung.com> References: <5553DCAE.2010208@osg.samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Darren Hart , Linux Kernel Mailing List Cc: linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ingo Molnar , Peter Zijlstra , Thomas Gleixner , Davidlohr Bueso , KOSAKI Motohiro , chrubis-AlSwsSmVLrQ@public.gmane.org, Shuah Khan List-Id: linux-api@vger.kernel.org On 05/13/2015 05:34 PM, Darren Hart wrote: > On 5/13/15, 4:22 PM, "Shuah Khan" wrote: > >> On 05/12/2015 10:07 PM, Darren Hart wrote: >>> Hi Shuah, >>> >>> This series begins the process of migrating my futextest tests into >>> kselftest. >>> I've started with only the functional tests, as the performance and >>> stress may >>> not be appropriate for kselftest as they stand. >>> >>> I cleaned up various complaints from checkpatch, but I ignored others >>> that would >>> require significant rework of the testcases, such as not using volatile >>> and not >>> creating new typedefs. >>> >> >> Daren, >> >> This patch series is good. kselftest run and install >> are good. I see the following results. Something you >> would expect?? > > Yes, that is all expected behavior if you don't run as root and your user > doesn't have the necessary capabilities added - similar to other tests > with privileged operations. > >> No Issues and I am going to get them >> into 4.2 - should show up in linux-kselftest next. > > Great, thanks. Perhaps some explicit capabilities tests and clearer error > messages would make sense as a follow-on patch. > > Thanks for working with me to get these into the kernel, I think it will > improve futex test exposure and hopefully encourage people to write more > tests to fill some of the gaps. > Applied to linux-kselftest next for 4.2 thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org | (970) 217-8978 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965453AbbENAkh (ORCPT ); Wed, 13 May 2015 20:40:37 -0400 Received: from lists.s-osg.org ([54.187.51.154]:60907 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754671AbbENAke (ORCPT ); Wed, 13 May 2015 20:40:34 -0400 Message-ID: <5553EF00.8080406@osg.samsung.com> Date: Wed, 13 May 2015 18:40:32 -0600 From: Shuah Khan Organization: Samsung Open Source Group User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Darren Hart , Linux Kernel Mailing List CC: linux-api@vger.kernel.org, Ingo Molnar , Peter Zijlstra , Thomas Gleixner , Davidlohr Bueso , KOSAKI Motohiro , chrubis@suse.cz, Shuah Khan Subject: Re: [PATCH v4 0/6] selftests: Add futex functional tests References: <5553DCAE.2010208@osg.samsung.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/13/2015 05:34 PM, Darren Hart wrote: > On 5/13/15, 4:22 PM, "Shuah Khan" wrote: > >> On 05/12/2015 10:07 PM, Darren Hart wrote: >>> Hi Shuah, >>> >>> This series begins the process of migrating my futextest tests into >>> kselftest. >>> I've started with only the functional tests, as the performance and >>> stress may >>> not be appropriate for kselftest as they stand. >>> >>> I cleaned up various complaints from checkpatch, but I ignored others >>> that would >>> require significant rework of the testcases, such as not using volatile >>> and not >>> creating new typedefs. >>> >> >> Daren, >> >> This patch series is good. kselftest run and install >> are good. I see the following results. Something you >> would expect?? > > Yes, that is all expected behavior if you don't run as root and your user > doesn't have the necessary capabilities added - similar to other tests > with privileged operations. > >> No Issues and I am going to get them >> into 4.2 - should show up in linux-kselftest next. > > Great, thanks. Perhaps some explicit capabilities tests and clearer error > messages would make sense as a follow-on patch. > > Thanks for working with me to get these into the kernel, I think it will > improve futex test exposure and hopefully encourage people to write more > tests to fill some of the gaps. > Applied to linux-kselftest next for 4.2 thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978