Re: [PATCH Remus v3 2/3] libxc/restore: add checkpointed flag to the restore context

[Yang Hongyang <yanghy@cn.fujitsu.com>]

On 05/13/2015 11:15 PM, Andrew Cooper wrote:
> On 13/05/15 09:35, Yang Hongyang wrote:
>> add checkpointed flag to the restore context.
>>
>> Signed-off-by: Yang Hongyang <yanghy@cn.fujitsu.com>
>> CC: Ian Campbell <Ian.Campbell@citrix.com>
>> CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
>> CC: Wei Liu <wei.liu2@citrix.com>
>> CC: Andrew Cooper <andrew.cooper3@citrix.com>
>
> This appears unused, given the new restore code.

This is used by handle_checkpoint() for the sanity check.

>
> ~Andrew
>
>> ---
>>   tools/libxc/xc_sr_common.h  | 3 +++
>>   tools/libxc/xc_sr_restore.c | 1 +
>>   2 files changed, 4 insertions(+)
>>
>> diff --git a/tools/libxc/xc_sr_common.h b/tools/libxc/xc_sr_common.h
>> index 0ba9728..f8121e7 100644
>> --- a/tools/libxc/xc_sr_common.h
>> +++ b/tools/libxc/xc_sr_common.h
>> @@ -205,6 +205,9 @@ struct xc_sr_context
>>               uint32_t guest_type;
>>               uint32_t guest_page_size;
>>
>> +            /* Plain VM, or checkpoints over time. */
>> +            bool checkpointed;
>> +
>>               /*
>>                * Xenstore and Console parameters.
>>                * INPUT:  evtchn & domid
>> diff --git a/tools/libxc/xc_sr_restore.c b/tools/libxc/xc_sr_restore.c
>> index 8022c3d..0e512ec 100644
>> --- a/tools/libxc/xc_sr_restore.c
>> +++ b/tools/libxc/xc_sr_restore.c
>> @@ -604,6 +604,7 @@ int xc_domain_restore2(xc_interface *xch, int io_fd, uint32_t dom,
>>       ctx.restore.console_domid = console_domid;
>>       ctx.restore.xenstore_evtchn = store_evtchn;
>>       ctx.restore.xenstore_domid = store_domid;
>> +    ctx.restore.checkpointed = checkpointed_stream;
>>       ctx.restore.callbacks = callbacks;
>>
>>       IPRINTF("In experimental %s", __func__);
>
> .
>

-- 
Thanks,
Yang.