From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46289) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yshdr-00077c-Vi for qemu-devel@nongnu.org; Wed, 13 May 2015 21:08:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yshdn-0007vw-VL for qemu-devel@nongnu.org; Wed, 13 May 2015 21:08:51 -0400 Message-ID: <5553F687.3040605@cn.fujitsu.com> Date: Thu, 14 May 2015 09:12:39 +0800 From: Wen Congyang MIME-Version: 1.0 References: <1431538099-3286-1-git-send-email-famz@redhat.com> <1431538099-3286-11-git-send-email-famz@redhat.com> <555333F9.5010307@cn.fujitsu.com> <20150513125506.GD30644@ad.nay.redhat.com> In-Reply-To: <20150513125506.GD30644@ad.nay.redhat.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 10/11] blockdev: Block device IO during blockdev-backup transaction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Kevin Wolf , qemu-block@nongnu.org, armbru@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com, Stefan Hajnoczi , pbonzini@redhat.com On 05/13/2015 08:55 PM, Fam Zheng wrote: > On Wed, 05/13 19:22, Wen Congyang wrote: >> On 05/14/2015 01:28 AM, Fam Zheng wrote: >>> Signed-off-by: Fam Zheng >>> --- >>> blockdev.c | 10 +++++++++- >>> 1 file changed, 9 insertions(+), 1 deletion(-) >>> >>> diff --git a/blockdev.c b/blockdev.c >>> index ae52d27..bd28183 100644 >>> --- a/blockdev.c >>> +++ b/blockdev.c >>> @@ -1649,6 +1649,7 @@ typedef struct BlockdevBackupState { >>> BlockDriverState *bs; >>> BlockJob *job; >>> AioContext *aio_context; >>> + Error *blocker; >>> } BlockdevBackupState; >>> >>> static void blockdev_backup_prepare(BlkTransactionState *common, Error **errp) >>> @@ -1685,6 +1686,10 @@ static void blockdev_backup_prepare(BlkTransactionState *common, Error **errp) >>> } >>> aio_context_acquire(state->aio_context); >>> >>> + state->bs = bs; >>> + error_setg(&state->blocker, "blockdev-backup in progress"); >>> + bdrv_op_block(bs, BLOCK_OP_TYPE_DEVICE_IO, state->blocker); >>> + >> >> Do you test this patch? You need to read from bs to do backup!! >> If the mode is none, you also need to write to bs!! > > This blocker is only temporary and is removed in blockdev_backup_clean before > qmp_transaction returns. Yes. Another question: We will use bdrv_op_block_all() in the job, and don't unblock BLOCK_OP_TYPE_DEVICE_IO. Is it OK? Thanks Wen Congyang > > Fam > >> >> Thanks >> Wen Congyang >> >>> qmp_blockdev_backup(backup->device, backup->target, >>> backup->sync, >>> backup->has_speed, backup->speed, >>> @@ -1696,7 +1701,6 @@ static void blockdev_backup_prepare(BlkTransactionState *common, Error **errp) >>> return; >>> } >>> >>> - state->bs = bs; >>> state->job = state->bs->job; >>> } >>> >>> @@ -1715,6 +1719,10 @@ static void blockdev_backup_clean(BlkTransactionState *common) >>> { >>> BlockdevBackupState *state = DO_UPCAST(BlockdevBackupState, common, common); >>> >>> + if (state->bs) { >>> + bdrv_op_unblock(state->bs, BLOCK_OP_TYPE_DEVICE_IO, state->blocker); >>> + error_free(state->blocker); >>> + } >>> if (state->aio_context) { >>> aio_context_release(state->aio_context); >>> } >>> >> > . >