From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiang Liu Subject: Re: [RFC v2 5/7] PCI/ACPI: Consolidate common PCI host bridge code into ACPI core Date: Thu, 14 May 2015 12:42:26 +0800 Message-ID: <555427B2.4040204@linux.intel.com> References: <1430793970-11159-1-git-send-email-jiang.liu@linux.intel.com> <1430793970-11159-6-git-send-email-jiang.liu@linux.intel.com> <55531967.70507@linaro.org> <55534275.2040404@linux.intel.com> <555350B2.8050301@linaro.org> <5553F5BF.2080802@linux.intel.com> <55541F17.5060005@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mga02.intel.com ([134.134.136.20]:13943 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751221AbbENEma (ORCPT ); Thu, 14 May 2015 00:42:30 -0400 In-Reply-To: <55541F17.5060005@linaro.org> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Hanjun Guo , "Rafael J . Wysocki" , Bjorn Helgaas , Marc Zyngier , Yijing Wang , Len Brown Cc: Lv Zheng , LKML , linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, "x86 @ kernel . org" , linux-arm-kernel@lists.infradead.org On 2015/5/14 12:05, Hanjun Guo wrote: > On 2015=E5=B9=B405=E6=9C=8814=E6=97=A5 09:09, Jiang Liu wrote: >> On 2015/5/13 21:25, Hanjun Guo wrote: >>> On 2015=E5=B9=B405=E6=9C=8813=E6=97=A5 20:24, Jiang Liu wrote: >>>> On 2015/5/13 17:29, Hanjun Guo wrote: >>>>> Hi Jiang, >>>>> >>>>> On 2015=E5=B9=B405=E6=9C=8805=E6=97=A5 10:46, Jiang Liu wrote: >>>>> >>>>> struct pci_controller { >>>>> struct acpi_device *companion; >>>>> void *iommu; >>>>> int segment; >>>>> int node; /* nearest node with memory or >>>>> NUMA_NO_NODE for global allocation */ >>>>> >>>>> void *platform_data; >>>>> }; >>>>> >>>>> except void *platform_data; >>>>> >>>>> On ARM64, the structure is almost the same, so how about >>>>> introduce >>>>> >>>>> struct pci_controller { >>>>> struct acpi_device *companion; /* ACPI companion devic= e */ >>>>> void *iommu; /* IOMMU private data *= / >>>>> int segment; /* PCI domain */ >>>>> int node; /* NUMA node */ >>>>> #ifdef CONFIG_IA64 >>>>> void *platform_data; >>>>> #endif >>>>> }; >>>>> >>>>> in this file, then can be used for all architectures? >>>> Current mode is that architecture defines its own version of >>>> struct pci_controller. It would be better to keep this pattern. >>> >>> OK, thanks for the clarify :) So how about add my basic >>> PCI support patch for ARM64 on top of you patch set to fix >>> this problem? >> >> Sure, please send me the patches and I will send out v3 to >> cover your review comments. >=20 > OK, I need to rework my patches because my patch set is dependent > on top of another MMCFG refactor patch set [1], so I need to remove > MMCONFIG first then will speed up the upstream process of your patch > set, will send you the patches soon. Hi Hanjun, I will send out v3 soon , so you could rebase onto v3. There are changes which will affect your rebase. Thanks! Gerry >=20 > [1]: https://lkml.org/lkml/2015/4/17/29 >=20 > Thanks > Hanjun -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <555427B2.4040204@linux.intel.com> Date: Thu, 14 May 2015 12:42:26 +0800 From: Jiang Liu MIME-Version: 1.0 To: Hanjun Guo , "Rafael J . Wysocki" , Bjorn Helgaas , Marc Zyngier , Yijing Wang , Len Brown CC: Lv Zheng , LKML , linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, "x86 @ kernel . org" , linux-arm-kernel@lists.infradead.org Subject: Re: [RFC v2 5/7] PCI/ACPI: Consolidate common PCI host bridge code into ACPI core References: <1430793970-11159-1-git-send-email-jiang.liu@linux.intel.com> <1430793970-11159-6-git-send-email-jiang.liu@linux.intel.com> <55531967.70507@linaro.org> <55534275.2040404@linux.intel.com> <555350B2.8050301@linaro.org> <5553F5BF.2080802@linux.intel.com> <55541F17.5060005@linaro.org> In-Reply-To: <55541F17.5060005@linaro.org> Content-Type: text/plain; charset=utf-8 Sender: linux-acpi-owner@vger.kernel.org List-ID: On 2015/5/14 12:05, Hanjun Guo wrote: > On 2015年05月14日 09:09, Jiang Liu wrote: >> On 2015/5/13 21:25, Hanjun Guo wrote: >>> On 2015年05月13日 20:24, Jiang Liu wrote: >>>> On 2015/5/13 17:29, Hanjun Guo wrote: >>>>> Hi Jiang, >>>>> >>>>> On 2015年05月05日 10:46, Jiang Liu wrote: >>>>> >>>>> struct pci_controller { >>>>> struct acpi_device *companion; >>>>> void *iommu; >>>>> int segment; >>>>> int node; /* nearest node with memory or >>>>> NUMA_NO_NODE for global allocation */ >>>>> >>>>> void *platform_data; >>>>> }; >>>>> >>>>> except void *platform_data; >>>>> >>>>> On ARM64, the structure is almost the same, so how about >>>>> introduce >>>>> >>>>> struct pci_controller { >>>>> struct acpi_device *companion; /* ACPI companion device */ >>>>> void *iommu; /* IOMMU private data */ >>>>> int segment; /* PCI domain */ >>>>> int node; /* NUMA node */ >>>>> #ifdef CONFIG_IA64 >>>>> void *platform_data; >>>>> #endif >>>>> }; >>>>> >>>>> in this file, then can be used for all architectures? >>>> Current mode is that architecture defines its own version of >>>> struct pci_controller. It would be better to keep this pattern. >>> >>> OK, thanks for the clarify :) So how about add my basic >>> PCI support patch for ARM64 on top of you patch set to fix >>> this problem? >> >> Sure, please send me the patches and I will send out v3 to >> cover your review comments. > > OK, I need to rework my patches because my patch set is dependent > on top of another MMCFG refactor patch set [1], so I need to remove > MMCONFIG first then will speed up the upstream process of your patch > set, will send you the patches soon. Hi Hanjun, I will send out v3 soon , so you could rebase onto v3. There are changes which will affect your rebase. Thanks! Gerry > > [1]: https://lkml.org/lkml/2015/4/17/29 > > Thanks > Hanjun From mboxrd@z Thu Jan 1 00:00:00 1970 From: jiang.liu@linux.intel.com (Jiang Liu) Date: Thu, 14 May 2015 12:42:26 +0800 Subject: [RFC v2 5/7] PCI/ACPI: Consolidate common PCI host bridge code into ACPI core In-Reply-To: <55541F17.5060005@linaro.org> References: <1430793970-11159-1-git-send-email-jiang.liu@linux.intel.com> <1430793970-11159-6-git-send-email-jiang.liu@linux.intel.com> <55531967.70507@linaro.org> <55534275.2040404@linux.intel.com> <555350B2.8050301@linaro.org> <5553F5BF.2080802@linux.intel.com> <55541F17.5060005@linaro.org> Message-ID: <555427B2.4040204@linux.intel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2015/5/14 12:05, Hanjun Guo wrote: > On 2015?05?14? 09:09, Jiang Liu wrote: >> On 2015/5/13 21:25, Hanjun Guo wrote: >>> On 2015?05?13? 20:24, Jiang Liu wrote: >>>> On 2015/5/13 17:29, Hanjun Guo wrote: >>>>> Hi Jiang, >>>>> >>>>> On 2015?05?05? 10:46, Jiang Liu wrote: >>>>> >>>>> struct pci_controller { >>>>> struct acpi_device *companion; >>>>> void *iommu; >>>>> int segment; >>>>> int node; /* nearest node with memory or >>>>> NUMA_NO_NODE for global allocation */ >>>>> >>>>> void *platform_data; >>>>> }; >>>>> >>>>> except void *platform_data; >>>>> >>>>> On ARM64, the structure is almost the same, so how about >>>>> introduce >>>>> >>>>> struct pci_controller { >>>>> struct acpi_device *companion; /* ACPI companion device */ >>>>> void *iommu; /* IOMMU private data */ >>>>> int segment; /* PCI domain */ >>>>> int node; /* NUMA node */ >>>>> #ifdef CONFIG_IA64 >>>>> void *platform_data; >>>>> #endif >>>>> }; >>>>> >>>>> in this file, then can be used for all architectures? >>>> Current mode is that architecture defines its own version of >>>> struct pci_controller. It would be better to keep this pattern. >>> >>> OK, thanks for the clarify :) So how about add my basic >>> PCI support patch for ARM64 on top of you patch set to fix >>> this problem? >> >> Sure, please send me the patches and I will send out v3 to >> cover your review comments. > > OK, I need to rework my patches because my patch set is dependent > on top of another MMCFG refactor patch set [1], so I need to remove > MMCONFIG first then will speed up the upstream process of your patch > set, will send you the patches soon. Hi Hanjun, I will send out v3 soon , so you could rebase onto v3. There are changes which will affect your rebase. Thanks! Gerry > > [1]: https://lkml.org/lkml/2015/4/17/29 > > Thanks > Hanjun