From: Nick Dyer <nick.dyer@itdev.co.uk>
To: Pan Xinhui <xinhuix.pan@intel.com>, linux-kernel@vger.kernel.org
Cc: dmitry.torokhov@gmail.com, yanmin_zhang@linux.intel.com, mnipxh@163.com
Subject: Re: [PATCH V2] atmel: fix a race between fw_load and data free
Date: Thu, 14 May 2015 12:31:16 +0100 [thread overview]
Message-ID: <55548784.3080505@itdev.co.uk> (raw)
In-Reply-To: <5555D639.90405@intel.com>
Hi-
This looks like a good tidy up, one minor comment:
On 15/05/15 12:19, Pan Xinhui wrote:
> + mxt_wait_for_completion(data, &data->fw_load_completion,
> + MXT_FW_RESET_TIME);
this should probably just be
wait_for_completion(&data->fw_load_completion);
rather than timing out (the MXT_FW_RESET_TIME may not be an appropriate
length anyway)
cheers
Nick
next prev parent reply other threads:[~2015-05-14 11:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-15 11:19 [PATCH V2] atmel: fix a race between fw_load and data free Pan Xinhui
2015-05-14 11:31 ` Nick Dyer [this message]
2015-05-15 12:37 ` Pan Xinhui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55548784.3080505@itdev.co.uk \
--to=nick.dyer@itdev.co.uk \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mnipxh@163.com \
--cc=xinhuix.pan@intel.com \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.