From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: [PATCHv4 5/5] x86: reduce struct hvm_domain size Date: Thu, 14 May 2015 13:08:12 +0100 Message-ID: <5554902C.10609@citrix.com> References: <1431355025-20468-1-git-send-email-david.vrabel@citrix.com> <1431355025-20468-6-git-send-email-david.vrabel@citrix.com> <20150514112435.GF81528@deinos.phlegethon.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Ysrw2-00022Z-Me for xen-devel@lists.xenproject.org; Thu, 14 May 2015 12:08:18 +0000 In-Reply-To: <20150514112435.GF81528@deinos.phlegethon.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tim Deegan Cc: Keir Fraser , Ian Campbell , Andrew Cooper , Jennifer Herbert , Jan Beulich , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On 14/05/15 12:24, Tim Deegan wrote: > At 15:37 +0100 on 11 May (1431358625), David Vrabel wrote: >> Pack struct hvm_domain to reduce it by 8 bytes. Thus reducing the >> size of struct domain by 8 bytes. > > In my builds (non-debug, on current staging), this makes no difference > to struct domain. struct hvm_domain gets 8 bytes smaller (2144 -> > 2136), but struct arch_domain remains at 2944 bytes (it just gets an > extra 8 bytes in the padding at the end to round it up to > __cacheline_aligned). It used to make a difference. Perhaps some other recently change negates the benefit? In which case, this patch could be dropped. David