From: Michael Wood <michael.g.wood@intel.com>
To: "toaster@yoctoproject.org" <toaster@yoctoproject.org>
Subject: [review-request] michaelw/fix-toaster-unittests
Date: Thu, 14 May 2015 16:41:29 +0100 [thread overview]
Message-ID: <5554C229.4090101@intel.com> (raw)
Special attention for review:
diff --git a/bitbake/lib/toaster/bldcontrol/localhostbecontroller.py
b/bitbake/lib/toaster/bldcontrol/localhostbecontroller.py
index 1bd5143..f0fe28e 100644
--- a/bitbake/lib/toaster/bldcontrol/localhostbecontroller.py
+++ b/bitbake/lib/toaster/bldcontrol/localhostbecontroller.py
@@ -117,7 +117,7 @@ class LocalhostBEController(BuildEnvironmentController):
f.seek(0, 2) # jump to the end
toaster_ui_log_filelength = f.tell()
- cmd = "bash -c \"source %s/oe-init-build-env %s 2>&1
>toaster_server.log && bitbake --read conf/toaster-pre.conf --postread
conf/toaster.conf --server-only -t xmlrpc -B 0.0.0.0:0 2>&1
>toaster_server.log && DATABASE_URL=%s BBSERVER=0.0.0.0:-1 daemon -d -i
-D %s -o toaster_ui.log -- %s --observe-only -u toasterui &\"" %
(self.pokydirname, self.be.builddir,
+ cmd = "bash -c \"source %s/oe-init-build-env %s 2>&1
>toaster_server.log && bitbake --read %s/conf/toaster-pre.conf
--postread %s/conf/toaster.conf --server-only -t xmlrpc -B 0.0.0.0:0
2>&1 >toaster_server.log && DATABASE_URL=%s BBSERVER=0.0.0.0:-1 daemon
-d -i -D %s -o toaster_ui.log -- %s --observe-only -u toasterui &\"" %
(self.pokydirname, self.be.builddir, self.be.builddir, self.be.builddir,
commit 0d9e2362821ecf42f690afc0a247fd228cbbd853
Author: Michael Wood <michael.g.wood@intel.com>
Date: Thu May 14 11:20:46 2015 +0100
bitbake: toaster: Fix all the toaster unit test cases
This fixes all the test cases that were broken and removes some of the
hard coded values that hindered the tests being run elsewhere.
Signed-off-by: Michael Wood <michael.g.wood@intel.com>
next reply other threads:[~2015-05-14 15:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-14 15:41 Michael Wood [this message]
2015-05-15 13:58 ` [review-request] michaelw/fix-toaster-unittests Damian, Alexandru
2015-05-20 14:50 ` Michael Wood
2015-05-21 10:14 ` Damian, Alexandru
2015-05-28 14:11 ` Damian, Alexandru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5554C229.4090101@intel.com \
--to=michael.g.wood@intel.com \
--cc=toaster@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.