Re: [PATCH net-next] test_bpf: fix sparse warnings

[Daniel Borkmann <daniel@iogearbox.net>]

On 05/14/2015 05:40 AM, Alexei Starovoitov wrote:
> From: Michael Holzheu <holzheu@linux.vnet.ibm.com>
>
> Fix several sparse warnings like:
> lib/test_bpf.c:1824:25: sparse: constant 4294967295 is so big it is long
> lib/test_bpf.c:1878:25: sparse: constant 0x0000ffffffff0000 is so big it is long
>
> Fixes: cffc642d93f9 ("test_bpf: add 173 new testcases for eBPF")
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Michael Holzheu <holzheu@linux.vnet.ibm.com>
> Signed-off-by: Alexei Starovoitov <ast@plumgrid.com>
> ---
>   lib/test_bpf.c |  122 ++++++++++++++++++++++++++++----------------------------
>   1 file changed, 61 insertions(+), 61 deletions(-)
>
...
>   	{
>   		"ALU_MOV_K: 0x0000ffffffff0000 = 0x00000000ffffffff",
>   		.u.insns_int = {
> -			BPF_LD_IMM64(R2, 0x0000ffffffff0000),
> -			BPF_LD_IMM64(R3, 0x00000000ffffffff),
> +			BPF_LD_IMM64(R2, 0x0000ffffffff0000LL),
> +			BPF_LD_IMM64(R3, 0x00000000ffffffffLL),

Should have been ULL, no? Anyway, the BPF_LD_IMM64() macro will cast it
correctly anyway.

Other than that:

Acked-by: Daniel Borkmann <daniel@iogearbox.net>