All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Haley <brian.haley@hp.com>
To: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: Jiri Pirko <jiri@resnulli.us>, David Miller <davem@davemloft.net>
Subject: [PATCH] fix net/sched compile error
Date: Thu, 14 May 2015 12:33:11 -0400	[thread overview]
Message-ID: <5554CE47.8070709@hp.com> (raw)

Fix compile error in net/sched/cls_flower.c

     net/sched/cls_flower.c: In function ‘fl_set_key’:
     net/sched/cls_flower.c:240:3: error: implicit declaration of function 
‘tcf_change_indev’ [-Werror=implicit-function-declaration]
        err = tcf_change_indev(net, tb[TCA_FLOWER_INDEV]);

Introduced in 77b9900ef53ae047e36a37d13a2aa33bb2d60641

Signed-off-by: Brian Haley <brian.haley@hp.com>

diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.c
index 9bc654c..8c8f34e 100644
--- a/net/sched/cls_flower.c
+++ b/net/sched/cls_flower.c
@@ -234,15 +234,15 @@ static void fl_set_key_val(struct nlattr **tb,
  static int fl_set_key(struct net *net, struct nlattr **tb,
  		      struct fl_flow_key *key, struct fl_flow_key *mask)
  {
-	int err;
-
+#ifdef CONFIG_NET_CLS_IND
  	if (tb[TCA_FLOWER_INDEV]) {
-		err = tcf_change_indev(net, tb[TCA_FLOWER_INDEV]);
+		int err = tcf_change_indev(net, tb[TCA_FLOWER_INDEV]);
  		if (err < 0)
  			return err;
  		key->indev_ifindex = err;
  		mask->indev_ifindex = 0xffffffff;
  	}
+#endif

  	fl_set_key_val(tb, key->eth.dst, TCA_FLOWER_KEY_ETH_DST,
  		       mask->eth.dst, TCA_FLOWER_KEY_ETH_DST_MASK,

             reply	other threads:[~2015-05-14 16:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-14 16:33 Brian Haley [this message]
2015-05-14 16:40 ` [PATCH] fix net/sched compile error David Miller
2015-05-14 19:56 ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5554CE47.8070709@hp.com \
    --to=brian.haley@hp.com \
    --cc=davem@davemloft.net \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.