From mboxrd@z Thu Jan  1 00:00:00 1970
From: Razvan Cojocaru <rcojocaru@bitdefender.com>
Subject: Re: [PATCH V2] xen/vm_event: Clean up
 control-register-write vm_events
Date: Thu, 14 May 2015 20:11:48 +0300
Message-ID: <5554D754.7060208@bitdefender.com>
References: <1431592849-18295-1-git-send-email-rcojocaru@bitdefender.com>
	<CAErYnshtsy2rPogVR=zmmzwVi+Y8ZA7QQmiv-9kDHO5wme+37Q@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CAErYnshtsy2rPogVR=zmmzwVi+Y8ZA7QQmiv-9kDHO5wme+37Q@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Tamas K Lengyel <tamas.lengyel@zentific.com>
Cc: "Tian, Kevin" <kevin.tian@intel.com>, "wei.liu2@citrix.com" <wei.liu2@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Tim Deegan <tim@xen.org>, Ian Jackson <ian.jackson@eu.citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Jan Beulich <jbeulich@suse.com>, "Dong, Eddie" <eddie.dong@intel.com>, Jun Nakajima <jun.nakajima@intel.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Keir Fraser <keir@xen.org>
List-Id: xen-devel@lists.xenproject.org

On 05/14/2015 07:55 PM, Tamas K Lengyel wrote:
>> diff --git a/xen/include/asm-x86/domain.h b/xen/include/asm-x86/domain.h
>> index 45b5283..1dd49dd 100644
>> --- a/xen/include/asm-x86/domain.h
>> +++ b/xen/include/asm-x86/domain.h
>> @@ -341,19 +341,13 @@ struct arch_domain
>>
>>      /* Monitor options */
>>      struct {
>> -        uint16_t mov_to_cr0_enabled          : 1;
>> -        uint16_t mov_to_cr0_sync             : 1;
>> -        uint16_t mov_to_cr0_onchangeonly     : 1;
>> -        uint16_t mov_to_cr3_enabled          : 1;
>> -        uint16_t mov_to_cr3_sync             : 1;
>> -        uint16_t mov_to_cr3_onchangeonly     : 1;
>> -        uint16_t mov_to_cr4_enabled          : 1;
>> -        uint16_t mov_to_cr4_sync             : 1;
>> -        uint16_t mov_to_cr4_onchangeonly     : 1;
>> -        uint16_t mov_to_msr_enabled          : 1;
>> -        uint16_t mov_to_msr_extended         : 1;
>> -        uint16_t singlestep_enabled          : 1;
>> -        uint16_t software_breakpoint_enabled : 1;
>> +        uint32_t write_ctrlreg_enabled       : 8;
>> +        uint32_t write_ctrlreg_sync          : 8;
>> +        uint32_t write_ctrlreg_onchangeonly  : 8;
> 
> Any particular reason why you have these bitmaps 8-bits wide? There
> are only 4 events defined at the moment that would use these.

ARM control registers have been mentioned, so I thought I would leave
some space for a few more events. Other than that, they don't _need_ to
be 8-bits wide. If compactness matters more I'll change them to 4.


Thanks,
Razvan