From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 51EE9E009BB; Thu, 14 May 2015 10:15:28 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [209.85.212.181 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 1AA39E00956 for ; Thu, 14 May 2015 10:15:23 -0700 (PDT) Received: by wibt6 with SMTP id t6so23472756wib.0 for ; Thu, 14 May 2015 10:15:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=j+3K/mkGrkt3R2cVFLkB91tAl8skvLGOaLoYu09e114=; b=KEdgR+CBHT5yEm5oPIZf+snfAUynCxKNRib2MabtJrtvA+VpeUpe+1LW1IUhkb4S7o 06ReCEQmpzKaFYOvrL7clJzhAcy6/V2d8pvrZnWS6UgGwcRE3OqJ7ZA2Cdczd/gVZLqX onXNSKSwh5gAVdDbfVYTSjDZZJEC/jQZvpVlwKoh50/xjJ2uZiskmcHhCyANNHqm7xYz vQwAXyfOn8Hp/0VUj43NZhaB63w8fXwD0I8s2DTHmCVMpvDqsIEl5PGoMXkEj5MkubB5 DBOsc+toB2ijbhq16SyouHt3iPhYoR/cyHzvWpx86JjU1GfTv1OcgRU+ahPjV+aT3+t6 Unwg== X-Gm-Message-State: ALoCoQkvsBLScvsvQdMHjToDlpTa07Jnr5VSktBcV6e3P46R+wl3VizmnquckK0zxwgmqlHRVjum X-Received: by 10.180.84.65 with SMTP id w1mr50019545wiy.20.1431623722679; Thu, 14 May 2015 10:15:22 -0700 (PDT) Received: from [192.168.2.24] ([83.217.123.106]) by mx.google.com with ESMTPSA id ew10sm14227595wic.22.2015.05.14.10.15.21 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 May 2015 10:15:21 -0700 (PDT) Message-ID: <5554D829.4070908@intel.com> Date: Thu, 14 May 2015 18:15:21 +0100 From: Michael Wood User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: toaster@yoctoproject.org References: In-Reply-To: Subject: Re: [review-request] adamian/20150506_toasterloggerfixes X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 May 2015 17:15:28 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Looks fine to me (though I'm not that familiar with the buildinfohelper side of things). Thanks On 14/05/15 16:58, Damian, Alexandru wrote: > Hi, > > I did a bit of refactoring on the toaster build logger which fixes > some issues, and clear up the path for future improvement. > > * the "local_path" property of the Layer is now moved to > Layer_Version. It was a mistake to assign specific build-local paths > to the generic Layer information, as it is naturally a property of a > specific Layer checkout, which is what a Layer Version is. > > * all the recipe paths are now relative to a Layer_Version checkout, > no more absolute paths. This allows us to link a recipe file directly > to a remote GIT repo of a Layer, if needed. > > * the "namespace" (e.g virtual:native: ) part of a recipe path is > stored in a new field; all paths are now clean paths, so they can be > manipulated as such. Storing the namespace separately should also fix > the mis-identification of tasks between native and normal tasks, for > example (multiple bugs opened on this one) > > * all the builds now occur under a Project. this is the first step for > the unification of Managed and Interactive modes. The UI interface is > not changed. > > * django auth tables are now created under interactive mode, too. This > allows us to get rid of the atrocity of storing display state on the > front-end cookies. Another step in the unification of modes. > > * some smaller fixes regarding data collection are in there. > > Can you please see if this makes sense to you ? > > Cheers, > Alex > > > -- > Alex Damian > Yocto Project > SSG / OTC > >