From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [RFC 4/4] xen/arm: Remove unnecessary GUEST_GICV3_GICR0_SIZE macro. Date: Thu, 14 May 2015 19:03:04 +0100 Message-ID: <5554E358.7080107@citrix.com> References: <1431612863-3762-1-git-send-email-cbz@baozis.org> <1431612863-3762-5-git-send-email-cbz@baozis.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YsxUT-0000u0-Rt for xen-devel@lists.xenproject.org; Thu, 14 May 2015 18:04:13 +0000 In-Reply-To: <1431612863-3762-5-git-send-email-cbz@baozis.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Chen Baozi , xen-devel@lists.xenproject.org Cc: julien.grall@citrix.com, Chen Baozi , ian.campbell@citrix.com List-Id: xen-devel@lists.xenproject.org Hi Chen, On 14/05/15 15:14, Chen Baozi wrote: > From: Chen Baozi > > Signed-off-by: Chen Baozi > --- > xen/include/public/arch-arm.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h > index c029e0f..cbcda74 100644 > --- a/xen/include/public/arch-arm.h > +++ b/xen/include/public/arch-arm.h > @@ -388,8 +388,7 @@ struct xen_arch_domainconfig { > #define GUEST_GICV3_RDIST_STRIDE 0x20000ULL > #define GUEST_GICV3_RDIST_REGIONS 1 > > -#define GUEST_GICV3_GICR0_BASE 0x03020000ULL /* vCPU0 - vCPU7 */ The /* vCPU0 - vCPU7 */ was useful. Please update to whatever you will be use. > -#define GUEST_GICV3_GICR0_SIZE 0x00100000ULL > +#define GUEST_GICV3_GICR0_BASE 0x03020000ULL Please don't drop it. Even if you dropped all the usage, it's necessary for documentation purpose. If someone wants to change the guest layout, he will know that the re-dist region will be this size. I would also like to keep the BUILD_BUG_ON in vgic-v3 in order to check if there is enough space reserved in the guest layout for the re-dist (see your patch #2). Regards, -- Julien Grall