All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@kernel.org>
Cc: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>,
	alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
	Brian Austin <brian.austin@cirrus.com>,
	Bard Liao <bardliao@realtek.com>,
	Oder Chiou <oder_chiou@realtek.com>,
	Wolfram Sang <wsa@the-dreams.de>,
	linux-kernel@vger.kernel.org, Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH] ASoC: codecs-ac97: make selectable in config
Date: Thu, 14 May 2015 21:38:55 +0200	[thread overview]
Message-ID: <5554F9CF.3020601@metafoo.de> (raw)
In-Reply-To: <20150514192847.GV2761@sirena.org.uk>

On 05/14/2015 09:28 PM, Mark Brown wrote:
> On Thu, May 14, 2015 at 09:24:15PM +0200, Lars-Peter Clausen wrote:
>> On 05/14/2015 09:10 PM, Mark Brown wrote:
>
>>> Does the select from SND_SOC_AC97_BUS actually happen if it is selected
>>> by SND_SOC_ALL_CODECS?  That's the issue, if it works now it's a
>>> relatively recent thing.
>
>> I'm not sure I fully understand what you mean.
>
>> The Kconfig entry for the CODEC has no 'depends on'. It does a 'select
>> SND_SOC_AC97_BUS', which means all built time dependencies are pulled in
>> this way. So if SND_SOC_ALL_CODECS selects the CODEC unconditionally that
>> should work fine, since no dependencies are bypassed.
>
> No, it's not just dependencies but also selects that get ignored (or
> used to anyway like I say) - a select just forces the symbol on.
>

select forces a symbol on regardless of whether its dependencies are met or 
not. But for any symbol that is on, no matter whether it was manually 
selected or selected by a 'select' from another symbol, any symbols selected 
by that symbol will be turned on. It's been that way as long as I can remember.

  reply	other threads:[~2015-05-14 19:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-09 22:12 [PATCH] ASoC: codecs-ac97: make selectable in config Maciej S. Szmigiero
2015-05-12 17:58 ` Mark Brown
2015-05-13 20:57   ` Maciej S. Szmigiero
2015-05-14 17:53     ` Mark Brown
2015-05-14 18:46       ` Lars-Peter Clausen
2015-05-14 19:10         ` Mark Brown
2015-05-14 19:10           ` Mark Brown
2015-05-14 19:24           ` Lars-Peter Clausen
2015-05-14 19:28             ` Mark Brown
2015-05-14 19:38               ` Lars-Peter Clausen [this message]
2015-05-14 19:43                 ` Mark Brown
2015-05-22 12:41 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5554F9CF.3020601@metafoo.de \
    --to=lars@metafoo.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=bardliao@realtek.com \
    --cc=brian.austin@cirrus.com \
    --cc=broonie@kernel.org \
    --cc=festevam@gmail.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mail@maciej.szmigiero.name \
    --cc=oder_chiou@realtek.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.de \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.