From: Ying Xue <ying.xue@windriver.com>
To: David Miller <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <eric.dumazet@gmail.com>,
<jiri@resnulli.us>, <sfeldma@gmail.com>
Subject: Re: [PATCH net-next v2] rocker: fix a neigh entry leak issue
Date: Fri, 15 May 2015 10:30:18 +0800 [thread overview]
Message-ID: <55555A3A.6030201@windriver.com> (raw)
In-Reply-To: <20150514.222624.838893967441144984.davem@davemloft.net>
On 05/15/2015 10:26 AM, David Miller wrote:
> From: Ying Xue <ying.xue@windriver.com>
> Date: Fri, 15 May 2015 09:33:25 +0800
>
>> Once we get a neighbour through looking up arp cache or creating a
>> new one in rocker_port_ipv4_resolve(), the neighbour's refcount is
>> already taken. But as we don't put the refcount again after it's
>> used, this makes the neighbour entry leaked.
>>
>> Suggested-by: Eric Dumazet <edumazet@google.com>
>> Acked-by: Jiri Pirko <jiri@resnulli.us>
>> Signed-off-by: Ying Xue <ying.xue@windriver.com>
>> ---
>> v2:
>> Add the checking of return value of neigh_create() with IS_ERR()
>> to avoid another crash, which is suggested by Eric Dumazet.
>
> Doesn't this leak exist in the 'net' tree?
>
> If so, why are you targetting such a bug fix for 'net-next'?
>
>
Sorry, I am used to develop in net-next tree. Please wait a moment, I will check
whether the issue also exists in net tree.
Regards,
Ying
prev parent reply other threads:[~2015-05-15 2:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-15 1:33 [PATCH net-next v2] rocker: fix a neigh entry leak issue Ying Xue
2015-05-15 1:59 ` Eric Dumazet
2015-05-15 2:26 ` David Miller
2015-05-15 2:30 ` Ying Xue [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55555A3A.6030201@windriver.com \
--to=ying.xue@windriver.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=sfeldma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.