From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?windows-1252?Q?Roger_Pau_Monn=E9?= Subject: Re: [PATCH] xen: blkif.h: document linux xen-block multi-page ring implementation Date: Fri, 15 May 2015 11:26:45 +0200 Message-ID: <5555BBD5.3000703@citrix.com> References: <1431428329-6497-1-git-send-email-bob.liu@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <1431428329-6497-1-git-send-email-bob.liu@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Bob Liu , xen-devel@lists.xen.org Cc: justing@spectralogic.com, david.vrabel@citrix.com List-Id: xen-devel@lists.xenproject.org El 12/05/15 a les 12.58, Bob Liu ha escrit: > After commit 1b1586eeeb8c ("xenbus_client: Extend interface to > support multi-page ring"), Linux xenbus driver can support multi-page rin= g. > = > Based on this interface, we got some impressive improvements by using mul= ti-page > ring in xen-block driver. If using 64 pages as the ring, the IOPS increas= ed > about 15 times for the throughput testing. > = > The Linux implementation reuses two 'DEPRECATED' nodes('max-ring-pages' a= nd > 'num-ring-pages), so that nothing would be broken. > Also removed the power of 2 limit and updated the default/max value accor= dingly. > > Signed-off-by: Bob Liu This looks fine IMHO, the only caveat I see is that you are revamping an old feature so we need to be careful that the implementation that's merged on Linux is compatible with the previous implementation. Acked-by: Roger Pau Monn=E9 Roger.