From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Vrabel <david.vrabel@citrix.com>
Subject: Re: [PATCH] xen: blkif.h: document linux xen-block
 multi-page ring implementation
Date: Fri, 15 May 2015 11:45:10 +0100
Message-ID: <5555CE36.8090308@citrix.com>
References: <1431428329-6497-1-git-send-email-bob.liu@oracle.com>
	<5555C1A9.3060106@citrix.com> <5555CCD9.5040305@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5555CCD9.5040305@oracle.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Bob Liu <bob.liu@oracle.com>, David Vrabel <david.vrabel@citrix.com>
Cc: justing@spectralogic.com, xen-devel@lists.xen.org, roger.pau@citrix.com
List-Id: xen-devel@lists.xenproject.org

On 15/05/15 11:39, Bob Liu wrote:
> 
> On 05/15/2015 05:51 PM, David Vrabel wrote:
>> On 12/05/15 11:58, Bob Liu wrote:
>>> After commit 1b1586eeeb8c ("xenbus_client: Extend interface to
>>> support multi-page ring"), Linux xenbus driver can support multi-page ring.
>>>
>>> Based on this interface, we got some impressive improvements by using multi-page
>>> ring in xen-block driver. If using 64 pages as the ring, the IOPS increased
>>> about 15 times for the throughput testing.
>>>
>>> The Linux implementation reuses two 'DEPRECATED' nodes('max-ring-pages' and
>>> 'num-ring-pages), so that nothing would be broken.
>>> Also removed the power of 2 limit and updated the default/max value accordingly.
>>
>> You can't drop the power of 2 restriction as there may be frontends that
>> support this old option (from before it was deprecated) and these may
>> not support non-powers of 2.
>>
> 
> After take a closer look I think we can fully reuse the current protocol which
> only uses 'ring-page-order' and 'max-ring-page-order'.
> And leave 'max-ring-pages' and 'num-ring-pages' to DEPRECATED.
> 
> In conclusion, the blkif.h don't need to be modified and I'll update Linux
> implementation to use 'ring-page-order' and 'max-ring-page-order' too.
> What do you think? Thank you!

This sounds fine.

David