From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49629) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YtDL2-0006a2-0A for qemu-devel@nongnu.org; Fri, 15 May 2015 06:59:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YtDKy-00009k-OX for qemu-devel@nongnu.org; Fri, 15 May 2015 06:59:31 -0400 Received: from cantor2.suse.de ([195.135.220.15]:48905 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YtDKy-00009S-HZ for qemu-devel@nongnu.org; Fri, 15 May 2015 06:59:28 -0400 Message-ID: <5555D18C.5050909@suse.de> Date: Fri, 15 May 2015 12:59:24 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC PATCH 21/34] arm: Rename all exceptions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite , Peter Crosthwaite Cc: Peter Maydell , Edgar Iglesias , Richard Henderson , "qemu-devel@nongnu.org Developers" , Soren Brinkmann Am 15.05.2015 um 07:43 schrieb Peter Crosthwaite: > On Sun, May 10, 2015 at 11:29 PM, Peter Crosthwaite > wrote: >> These are architecture specific, and via cpu.h visibile in common >> and global namespaces. Preface them with "ARMAR_" to avoid namespace >> collisions. Prepares support for multi-arch where multiple cpu.h's >> can be included by device land code and namespace issues happen with >> such generic names. >> >> Use prefix ARM"AR" as the trap table is separate from the M-profile >> support, so qualify with AR to make it specific to A/R profile. ARM_AR_ would sound more appealing to me. > So I am not exactly sure what to do here going forward. This is going > to get messy with all the other arches. There are alternatives: >=20 > 1: Split these arch-specific private defs to a new header. internals.h > or a new header. which every way we go though the header needs to be > exported to linux-user code (awkward). > 2: Purge all device-land uses of cpu.h. They should be able to use > cpu-qom.h Negative, my plans to make cpu-qom.h generally usable failed as env turned out as embedded struct rather than pointer, and cpu-qom.h thus depends on stuff defined in cpu.h before its inclusion of cpu-qom.h. Therefore I told contributors of new targets that the current split makes no sense for their new targets. I would prefer 1. independent of whether we rename them or not. We need a better distinction of internal vs. external for targets. Regards, Andreas > and the random bits of machine-model code reaching into the > env or strobing interrupts needs to be fixed. > 3: This patch or something like it. >=20 > Regards, > Peter --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Felix Imend=C3=B6rffer, Jane Smithard, Dilip Upmanyu, Graham Norton; = HRB 21284 (AG N=C3=BCrnberg)