From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56677) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YtDp7-0007dy-Al for qemu-devel@nongnu.org; Fri, 15 May 2015 07:30:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YtDp2-0003jZ-Qu for qemu-devel@nongnu.org; Fri, 15 May 2015 07:30:37 -0400 Received: from cantor2.suse.de ([195.135.220.15]:52063 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YtDp2-0003jP-Ko for qemu-devel@nongnu.org; Fri, 15 May 2015 07:30:32 -0400 Message-ID: <5555D8D6.6060300@suse.de> Date: Fri, 15 May 2015 13:30:30 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC PATCH 00/34] Multi Architecture System Emulation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite , Peter Crosthwaite Cc: Peter Maydell , Edgar Iglesias , Richard Henderson , "qemu-devel@nongnu.org Developers" , Soren Brinkmann Am 15.05.2015 um 08:59 schrieb Peter Crosthwaite: > On Sun, May 10, 2015 at 11:29 PM, Peter Crosthwaite > wrote: >> The helper function namespace is going to be tricky. I haven't tackled= the >> problem just yet, but looking for ideas on how we can avoid prefacing = all >> helpers with arch prefixes to avoid link-time collisions because multi= ple >> arches use the same helper names. >=20 > Ok so have half a plan here now for the helper link-time namespace > problem. The top level HELPER() macro can be patched to glue() in an > architecture name set by cpu.h. The every use of HELPER(foo) will be > namespace collision free. The catch? Some arches mass-use literal > helper_foo for defs and calls. I've always disliked that inconcistency, so +1 for forcing the use of HELPER(). Will also make it easier to switch the CPU argument some day. Cheers, Andreas > Fortunately ARM is well behaved and > only has about 4 usages so thats an easy convert. Microblaze has more. > It will be a reasonably simple (but tedious) scripted changed to > convert uses and definitions of helper_foo to HELPER(foo) but it saves > on the verbosity of having to go in and preface everything (all of > callsites, definitions and helper.h defs themselves). >=20 > Regards, > Peter --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Felix Imend=C3=B6rffer, Jane Smithard, Dilip Upmanyu, Graham Norton; = HRB 21284 (AG N=C3=BCrnberg)