From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38524)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Leon.Alrae@imgtec.com>) id 1YtEQU-00088h-BT
	for qemu-devel@nongnu.org; Fri, 15 May 2015 08:09:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Leon.Alrae@imgtec.com>) id 1YtEQQ-0002qp-56
	for qemu-devel@nongnu.org; Fri, 15 May 2015 08:09:14 -0400
Received: from mailapp01.imgtec.com ([195.59.15.196]:63453)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Leon.Alrae@imgtec.com>) id 1YtEQP-0002qT-Vb
	for qemu-devel@nongnu.org; Fri, 15 May 2015 08:09:10 -0400
Message-ID: <5555E1DE.1010506@imgtec.com>
Date: Fri, 15 May 2015 13:09:02 +0100
From: Leon Alrae <leon.alrae@imgtec.com>
MIME-Version: 1.0
References: <1431531457-17127-1-git-send-email-yongbok.kim@imgtec.com>	<1431531457-17127-3-git-send-email-yongbok.kim@imgtec.com>	<5553A5C4.6030902@twiddle.net>
	<55546FF2.1030405@imgtec.com> <5554BED5.3070802@twiddle.net>
	<5554F38E.3070503@twiddle.net>
In-Reply-To: <5554F38E.3070503@twiddle.net>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 2/2] target-mips: Misaligned memory
 accesses for MSA
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>, Yongbok Kim <yongbok.kim@imgtec.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, afaerber@suse.de, Paolo Bonzini <pbonzini@redhat.com>

On 14/05/2015 20:12, Richard Henderson wrote:
>   /* We know both pages are present and writable.  */
>   if (eaddr == baddr + 15) {
>       /* Consecutive pages in RAM.  */
>       memcpy(baddr, register, 16);
>   } else {
>       /* Someone's doing an MSA store to device memory.  */
>       for (i = 0; i < 2; ++i) {
>           helper_ret_stq_mmu(env, vaddr + i*8, register.d[0],
>                              make_memop_idx(MO_UNALN | MO_TEQ, mmu_idx),
>                              GETRA());
>       }
>   }

We would additionally need to take care of vector elements' endianness
before using this code. Therefore always using helper_ret_st[bwlq]_mmu
(depending on data format) in a loop probably is simpler.

Leon