All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juergen Gross <jgross@suse.com>
To: linux-kernel@vger.kernel.org, x86@kernel.org, hpa@zytor.com,
	tglx@linutronix.de, mingo@redhat.com,
	xen-devel@lists.xensource.com, konrad.wilk@oracle.com,
	david.vrabel@citrix.com, boris.ostrovsky@oracle.com,
	jeremy@goop.org, chrisw@sous-sol.org, akataria@vmware.com,
	rusty@rustcorp.com.au, virtualization@lists.linux-foundation.org,
	gleb@kernel.org, pbonzini@redhat.com, kvm@vger.kernel.org
Subject: Re: [PATCH 0/6] x86: reduce paravirtualized spinlock overhead
Date: Fri, 15 May 2015 14:16:24 +0200	[thread overview]
Message-ID: <5555E398.2070006@suse.com> (raw)
In-Reply-To: <1430391243-7112-1-git-send-email-jgross@suse.com>

Ping?

On 04/30/2015 12:53 PM, Juergen Gross wrote:
> Paravirtualized spinlocks produce some overhead even if the kernel is
> running on bare metal. The main reason are the more complex locking
> and unlocking functions. Especially unlocking is no longer just one
> instruction but so complex that it is no longer inlined.
>
> This patch series addresses this issue by adding two more pvops
> functions to reduce the size of the inlined spinlock functions. When
> running on bare metal unlocking is again basically one instruction.
>
> Compile tested with CONFIG_PARAVIRT_SPINLOCKS on and off, 32 and 64
> bits.
>
> Functional testing on bare metal and as Xen dom0.
>
> Correct patching verified by disassembly of active kernel.
>
> Juergen Gross (6):
>    x86: use macro instead of "0" for setting TICKET_SLOWPATH_FLAG
>    x86: move decision about clearing slowpath flag into arch_spin_lock()
>    x86: introduce new pvops function clear_slowpath
>    x86: introduce new pvops function spin_unlock
>    x86: switch config from UNINLINE_SPIN_UNLOCK to INLINE_SPIN_UNLOCK
>    x86: remove no longer needed paravirt_ticketlocks_enabled
>
>   arch/x86/Kconfig                      |  1 -
>   arch/x86/include/asm/paravirt.h       | 13 +++++++++
>   arch/x86/include/asm/paravirt_types.h | 12 ++++++++
>   arch/x86/include/asm/spinlock.h       | 53 ++++++++++++-----------------------
>   arch/x86/include/asm/spinlock_types.h |  3 +-
>   arch/x86/kernel/kvm.c                 | 14 +--------
>   arch/x86/kernel/paravirt-spinlocks.c  | 42 +++++++++++++++++++++++++--
>   arch/x86/kernel/paravirt.c            | 12 ++++++++
>   arch/x86/kernel/paravirt_patch_32.c   | 25 +++++++++++++++++
>   arch/x86/kernel/paravirt_patch_64.c   | 24 ++++++++++++++++
>   arch/x86/xen/spinlock.c               | 23 +--------------
>   include/linux/spinlock_api_smp.h      |  2 +-
>   kernel/Kconfig.locks                  |  7 +++--
>   kernel/Kconfig.preempt                |  3 +-
>   kernel/locking/spinlock.c             |  2 +-
>   lib/Kconfig.debug                     |  1 -
>   16 files changed, 154 insertions(+), 83 deletions(-)
>

  parent reply	other threads:[~2015-05-15 12:16 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-30 10:53 [PATCH 0/6] x86: reduce paravirtualized spinlock overhead Juergen Gross
2015-04-30 10:53 ` [PATCH 1/6] x86: use macro instead of "0" for setting TICKET_SLOWPATH_FLAG Juergen Gross
2015-04-30 10:53 ` Juergen Gross
2015-04-30 10:53 ` [PATCH 2/6] x86: move decision about clearing slowpath flag into arch_spin_lock() Juergen Gross
2015-04-30 10:53 ` Juergen Gross
2015-04-30 10:54 ` [PATCH 3/6] x86: introduce new pvops function clear_slowpath Juergen Gross
2015-04-30 10:54 ` Juergen Gross
2015-04-30 10:54 ` [PATCH 4/6] x86: introduce new pvops function spin_unlock Juergen Gross
2015-04-30 10:54 ` Juergen Gross
2015-04-30 10:54 ` [PATCH 5/6] x86: switch config from UNINLINE_SPIN_UNLOCK to INLINE_SPIN_UNLOCK Juergen Gross
2015-04-30 10:54 ` Juergen Gross
2015-04-30 10:54 ` [PATCH 6/6] x86: remove no longer needed paravirt_ticketlocks_enabled Juergen Gross
2015-04-30 10:54 ` Juergen Gross
2015-04-30 16:39 ` [PATCH 0/6] x86: reduce paravirtualized spinlock overhead Jeremy Fitzhardinge
2015-05-04  5:55   ` Juergen Gross
2015-05-05 17:21     ` Jeremy Fitzhardinge
2015-05-06 11:55       ` Juergen Gross
2015-05-17  5:30         ` Ingo Molnar
2015-05-17  5:30           ` Ingo Molnar
2015-05-18  8:11           ` Juergen Gross
2015-05-18  8:11             ` Juergen Gross
2015-04-30 16:39 ` Jeremy Fitzhardinge
2015-05-15 12:16 ` Juergen Gross
2015-05-15 12:16 ` Juergen Gross [this message]
2015-06-08  4:09 ` Juergen Gross
2015-06-16 14:37 ` Juergen Gross
2015-06-16 15:18   ` Thomas Gleixner
2015-06-16 15:18   ` Thomas Gleixner
2015-06-16 14:37 ` Juergen Gross
  -- strict thread matches above, loose matches on Subject: below --
2015-04-30 10:53 Juergen Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5555E398.2070006@suse.com \
    --to=jgross@suse.com \
    --cc=akataria@vmware.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=chrisw@sous-sol.org \
    --cc=david.vrabel@citrix.com \
    --cc=gleb@kernel.org \
    --cc=hpa@zytor.com \
    --cc=jeremy@goop.org \
    --cc=konrad.wilk@oracle.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=rusty@rustcorp.com.au \
    --cc=tglx@linutronix.de \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.