From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Cc: Keir Fraser <keir@xen.org>
Subject: Re: [PATCH] x86emul: also put_fpu() on error paths
Date: Fri, 15 May 2015 14:18:57 +0100 [thread overview]
Message-ID: <5555F241.6020600@citrix.com> (raw)
In-Reply-To: <555604A2020000780007A8CD@mail.emea.novell.com>
On 15/05/15 13:37, Jan Beulich wrote:
> fail_if() and generate_exception_if() could theoretically bypass the
> normal flow reaching put_fpu(), and not invoking it would leave the
> fpu_exception_callback pointer in place, allowing for the callback to
> be called at an unexpected time. Luckily the two
> generate_exception_if()-s that would actually trigger this are
> currently commented out, so this is not (yet) a (security) issue.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
prev parent reply other threads:[~2015-05-15 13:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-15 12:37 [PATCH] x86emul: also put_fpu() on error paths Jan Beulich
2015-05-15 13:18 ` Andrew Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5555F241.6020600@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.