From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH v9 4/4] libxl: Add interface for querying
 hypervisor about PCI topology
Date: Fri, 15 May 2015 09:21:34 -0400
Message-ID: <5555F2DE.3040602@oracle.com>
References: <1431361890-3466-1-git-send-email-boris.ostrovsky@oracle.com>
	<1431361890-3466-5-git-send-email-boris.ostrovsky@oracle.com>
	<20150515084357.GA1405@aepfle.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20150515084357.GA1405@aepfle.de>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Olaf Hering <olaf@aepfle.de>
Cc: wei.liu2@citrix.com, xen-devel@lists.xen.org, ian.jackson@eu.citrix.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

On 05/15/2015 04:43 AM, Olaf Hering wrote:
> On Mon, May 11, Boris Ostrovsky wrote:
>
>> +++ b/tools/libxl/xl_cmdimpl.c
>> @@ -5420,12 +5420,15 @@ static void output_numainfo(void)
>>   
>>   static void output_topologyinfo(void)
>> +    int valid_devs;
>> +            valid_devs++;
>> +    if (valid_devs == 0)
>
> This is broken as well, merged as e78e8b9bb649bf0f18d940fb12a4f6c55be34915
>

I will send a patch but I am curious whether this broke the build for 
you too? Because I didn't get any warnings.


-boris