From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Borntraeger Subject: Re: [PATCH v4 02/12] KVM: define common KVM_GUESTDBG_USE_SW/HW_BP bits Date: Fri, 15 May 2015 17:42:42 +0200 Message-ID: <555613F2.9060204@de.ibm.com> References: <1431700035-23479-1-git-send-email-alex.bennee@linaro.org> <1431700035-23479-3-git-send-email-alex.bennee@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 41E835176D for ; Fri, 15 May 2015 11:33:42 -0400 (EDT) Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id h12J0EJ1sxa4 for ; Fri, 15 May 2015 11:33:41 -0400 (EDT) Received: from e06smtp11.uk.ibm.com (e06smtp11.uk.ibm.com [195.75.94.107]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 1746B51768 for ; Fri, 15 May 2015 11:33:40 -0400 (EDT) Received: from /spool/local by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 15 May 2015 16:42:49 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id CCDCA219005C for ; Fri, 15 May 2015 16:42:27 +0100 (BST) Received: from d06av08.portsmouth.uk.ibm.com (d06av08.portsmouth.uk.ibm.com [9.149.37.249]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t4FFgk2P10944958 for ; Fri, 15 May 2015 15:42:46 GMT Received: from d06av08.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t4FFgiMT021877 for ; Fri, 15 May 2015 09:42:46 -0600 In-Reply-To: <1431700035-23479-3-git-send-email-alex.bennee@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu To: =?UTF-8?B?QWxleCBCZW5uw6ll?= , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, christoffer.dall@linaro.org, marc.zyngier@arm.com, peter.maydell@linaro.org, agraf@suse.de, drjones@redhat.com, pbonzini@redhat.com, zhichao.huang@linaro.org Cc: Tony Krowiak , Alexey Kardashevskiy , Benjamin Herrenschmidt , Heiko Carstens , Paul Mackerras , "H. Peter Anvin" , S390 , Michael Mueller , Nadav Amit , Michael Ellerman , "maintainer:X86 ARCHITECTURE..." , supporter@lists.cs.columbia.edu, Ingo Molnar , "Jason J. Herne" , jan.kiszka@siemens.com, bp@suse.de, Gleb Natapov , r65777@freescale.com, Cornelia Huck , Thomas Gleixner , Eric Farman , list@lists.cs.columbia.edu, ABI/API , open list List-Id: kvmarm@lists.cs.columbia.edu QW0gMTUuMDUuMjAxNSB1bSAxNjoyNyBzY2hyaWViIEFsZXggQmVubsOpZToKPiArKysgYi9hcmNo L3MzOTAvaW5jbHVkZS91YXBpL2FzbS9rdm0uaAo+IEBAIC0xMTQsOCArMTE0LDYgQEAgc3RydWN0 IGt2bV9mcHUgewo+ICAJX191NjQgZnByc1sxNl07Cj4gIH07Cj4gCj4gLSNkZWZpbmUgS1ZNX0dV RVNUREJHX1VTRV9IV19CUAkJMHgwMDAxMDAwMApbLi4uXQo+ICsrKyBiL2luY2x1ZGUvdWFwaS9s aW51eC9rdm0uaApbLi4uXQo+ICsjZGVmaW5lIEtWTV9HVUVTVERCR19VU0VfU1dfQlAJCSgxIDw8 IDE2KQo+ICsjZGVmaW5lIEtWTV9HVUVTVERCR19VU0VfSFdfQlAJCSgxIDw8IDE3KQoKVGhpcyBp cyBhbiBBQkkgYnJlYWsgZm9yIHMzOTAsIG5vPwoKRGF2aWQsIGRvIHlvdSByZW1lbWJlciB3aHkg d2UgZG8gbm90IHVzZSBLVk1fR1VFU1REQkdfVVNFX1NXX0JQPwoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18Ka3ZtYXJtIG1haWxpbmcgbGlzdAprdm1hcm1A bGlzdHMuY3MuY29sdW1iaWEuZWR1Cmh0dHBzOi8vbGlzdHMuY3MuY29sdW1iaWEuZWR1L21haWxt YW4vbGlzdGluZm8va3ZtYXJtCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e06smtp12.uk.ibm.com (e06smtp12.uk.ibm.com [195.75.94.108]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 129FD1A04A2 for ; Sat, 16 May 2015 01:42:52 +1000 (AEST) Received: from /spool/local by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 15 May 2015 16:42:49 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 5F99E17D8042 for ; Fri, 15 May 2015 16:43:36 +0100 (BST) Received: from d06av08.portsmouth.uk.ibm.com (d06av08.portsmouth.uk.ibm.com [9.149.37.249]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t4FFgkIv10748280 for ; Fri, 15 May 2015 15:42:46 GMT Received: from d06av08.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t4FFgiMX021877 for ; Fri, 15 May 2015 09:42:46 -0600 Message-ID: <555613F2.9060204@de.ibm.com> Date: Fri, 15 May 2015 17:42:42 +0200 From: Christian Borntraeger MIME-Version: 1.0 To: =?UTF-8?B?QWxleCBCZW5uw6ll?= , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, christoffer.dall@linaro.org, marc.zyngier@arm.com, peter.maydell@linaro.org, agraf@suse.de, drjones@redhat.com, pbonzini@redhat.com, zhichao.huang@linaro.org Subject: Re: [PATCH v4 02/12] KVM: define common KVM_GUESTDBG_USE_SW/HW_BP bits References: <1431700035-23479-1-git-send-email-alex.bennee@linaro.org> <1431700035-23479-3-git-send-email-alex.bennee@linaro.org> In-Reply-To: <1431700035-23479-3-git-send-email-alex.bennee@linaro.org> Content-Type: text/plain; charset=utf-8 Cc: Tony Krowiak , Alexey Kardashevskiy , Heiko Carstens , Bharat Bhushan , Paul Mackerras , "H. Peter Anvin" , S390 , Michael Mueller , Nadav Amit , "maintainer:X86 ARCHITECTURE..." , Ingo Molnar , "Jason J. Herne" , jan.kiszka@siemens.com, Mihai Caraman , bp@suse.de, Gleb Natapov , r65777@freescale.com, Cornelia Huck , Thomas Gleixner , Eric Farman , ABI/API , open list , Dominik Dingel , dahi@linux.vnet.ibm.com, Martin Schwidefsky , S390 , "open list:LINUX FOR POWERPC..." List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Am 15.05.2015 um 16:27 schrieb Alex Bennée: > +++ b/arch/s390/include/uapi/asm/kvm.h > @@ -114,8 +114,6 @@ struct kvm_fpu { > __u64 fprs[16]; > }; > > -#define KVM_GUESTDBG_USE_HW_BP 0x00010000 [...] > +++ b/include/uapi/linux/kvm.h [...] > +#define KVM_GUESTDBG_USE_SW_BP (1 << 16) > +#define KVM_GUESTDBG_USE_HW_BP (1 << 17) This is an ABI break for s390, no? David, do you remember why we do not use KVM_GUESTDBG_USE_SW_BP? From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Borntraeger Subject: Re: [PATCH v4 02/12] KVM: define common KVM_GUESTDBG_USE_SW/HW_BP bits Date: Fri, 15 May 2015 17:42:42 +0200 Message-ID: <555613F2.9060204@de.ibm.com> References: <1431700035-23479-1-git-send-email-alex.bennee@linaro.org> <1431700035-23479-3-git-send-email-alex.bennee@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Tony Krowiak , Alexey Kardashevskiy , Benjamin Herrenschmidt , Heiko Carstens , Paul Mackerras , "H. Peter Anvin" , S390 , Michael Mueller , Nadav Amit , Michael Ellerman , "maintainer:X86 ARCHITECTURE..." , supporter@lists.cs.columbia.edu, Ingo Molnar , "Jason J. Herne" , jan.kiszka@siemens.com, bp@suse.de, Gleb Natapov , r65777@freescale.com, Cornelia Huck , Thomas Gleixner , Eric Farman , list@lists.cs.columbia.edu, ABI/API , open list , To: =?UTF-8?B?QWxleCBCZW5uw6ll?= , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, christoffer.dall@linaro.org, marc.zyngier@arm.com, peter.maydell@linaro.org, agraf@suse.de, drjones@redhat.com, pbonzini@redhat.com, zhichao.huang@linaro.org Return-path: In-Reply-To: <1431700035-23479-3-git-send-email-alex.bennee@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu List-Id: kvm.vger.kernel.org QW0gMTUuMDUuMjAxNSB1bSAxNjoyNyBzY2hyaWViIEFsZXggQmVubsOpZToKPiArKysgYi9hcmNo L3MzOTAvaW5jbHVkZS91YXBpL2FzbS9rdm0uaAo+IEBAIC0xMTQsOCArMTE0LDYgQEAgc3RydWN0 IGt2bV9mcHUgewo+ICAJX191NjQgZnByc1sxNl07Cj4gIH07Cj4gCj4gLSNkZWZpbmUgS1ZNX0dV RVNUREJHX1VTRV9IV19CUAkJMHgwMDAxMDAwMApbLi4uXQo+ICsrKyBiL2luY2x1ZGUvdWFwaS9s aW51eC9rdm0uaApbLi4uXQo+ICsjZGVmaW5lIEtWTV9HVUVTVERCR19VU0VfU1dfQlAJCSgxIDw8 IDE2KQo+ICsjZGVmaW5lIEtWTV9HVUVTVERCR19VU0VfSFdfQlAJCSgxIDw8IDE3KQoKVGhpcyBp cyBhbiBBQkkgYnJlYWsgZm9yIHMzOTAsIG5vPwoKRGF2aWQsIGRvIHlvdSByZW1lbWJlciB3aHkg d2UgZG8gbm90IHVzZSBLVk1fR1VFU1REQkdfVVNFX1NXX0JQPwoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18Ka3ZtYXJtIG1haWxpbmcgbGlzdAprdm1hcm1A bGlzdHMuY3MuY29sdW1iaWEuZWR1Cmh0dHBzOi8vbGlzdHMuY3MuY29sdW1iaWEuZWR1L21haWxt YW4vbGlzdGluZm8va3ZtYXJtCg==