From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Borntraeger Subject: Re: [PATCH v4 02/12] KVM: define common KVM_GUESTDBG_USE_SW/HW_BP bits Date: Fri, 15 May 2015 17:58:38 +0200 Message-ID: <555617AE.9030508@de.ibm.com> References: <1431700035-23479-1-git-send-email-alex.bennee@linaro.org> <1431700035-23479-3-git-send-email-alex.bennee@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id DF2D65177B for ; Fri, 15 May 2015 11:49:37 -0400 (EDT) Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zGUMIzcHhxHr for ; Fri, 15 May 2015 11:49:37 -0400 (EDT) Received: from e06smtp12.uk.ibm.com (e06smtp12.uk.ibm.com [195.75.94.108]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 1B7A6516FA for ; Fri, 15 May 2015 11:49:36 -0400 (EDT) Received: from /spool/local by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 15 May 2015 16:58:47 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 18AA817D8056 for ; Fri, 15 May 2015 16:59:35 +0100 (BST) Received: from d06av04.portsmouth.uk.ibm.com (d06av04.portsmouth.uk.ibm.com [9.149.37.216]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t4FFwjeM9306498 for ; Fri, 15 May 2015 15:58:45 GMT Received: from d06av04.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av04.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t4FFweC1021317 for ; Fri, 15 May 2015 09:58:45 -0600 In-Reply-To: <1431700035-23479-3-git-send-email-alex.bennee@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu To: =?UTF-8?B?QWxleCBCZW5uw6ll?= , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, christoffer.dall@linaro.org, marc.zyngier@arm.com, peter.maydell@linaro.org, agraf@suse.de, drjones@redhat.com, pbonzini@redhat.com, zhichao.huang@linaro.org Cc: Tony Krowiak , Alexey Kardashevskiy , Benjamin Herrenschmidt , Heiko Carstens , Paul Mackerras , "H. Peter Anvin" , linux-s390@vger.kernel.org, Michael Mueller , Nadav Amit , Michael Ellerman , x86@kernel.org, Ingo Molnar , "Jason J. Herne" , jan.kiszka@siemens.com, bp@suse.de, Gleb Natapov , r65777@freescale.com, Cornelia Huck , Thomas Gleixner , Eric Farman , linux-api@vger.kernel.org, open list , Dominik Dingel , dahi@linux.vnet.ibm.com, Martin Schwidefsky List-Id: kvmarm@lists.cs.columbia.edu QW0gMTUuMDUuMjAxNSB1bSAxNjoyNyBzY2hyaWViIEFsZXggQmVubsOpZToKPiBpbmRleCBlZjFh NWZjLi5hY2E0Zjg2IDEwMDY0NAo+IC0tLSBhL2FyY2gvczM5MC9pbmNsdWRlL3VhcGkvYXNtL2t2 bS5oCj4gKysrIGIvYXJjaC9zMzkwL2luY2x1ZGUvdWFwaS9hc20va3ZtLmgKPiBAQCAtMTE0LDgg KzExNCw2IEBAIHN0cnVjdCBrdm1fZnB1IHsKPiAgCV9fdTY0IGZwcnNbMTZdOwo+ICB9Owo+IAo+ IC0jZGVmaW5lIEtWTV9HVUVTVERCR19VU0VfSFdfQlAJCTB4MDAwMTAwMDAKPiAtCgoKPiBkaWZm IC0tZ2l0IGEvaW5jbHVkZS91YXBpL2xpbnV4L2t2bS5oIGIvaW5jbHVkZS91YXBpL2xpbnV4L2t2 bS5oCj4gaW5kZXggNzBhYzY0MS4uN2M1ZGQxMSAxMDA2NDQKPiAtLS0gYS9pbmNsdWRlL3VhcGkv bGludXgva3ZtLmgKPiArKysgYi9pbmNsdWRlL3VhcGkvbGludXgva3ZtLmgKWy4uLl0KPiArI2Rl ZmluZSBLVk1fR1VFU1REQkdfVVNFX1NXX0JQCQkoMSA8PCAxNikKPiArI2RlZmluZSBLVk1fR1VF U1REQkdfVVNFX0hXX0JQCQkoMSA8PCAxNykKClRoaXMgaXMgYSBhYmkgYnJlYWsgZm9yIHMzOTAs IG5vPwoKRGF2aWQgZG8geW91IHJlbWVtYmVyIHdoeSB3ZSBkaWQgbm90IHVzZSBTV19CUD8KCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmt2bWFybSBtYWls aW5nIGxpc3QKa3ZtYXJtQGxpc3RzLmNzLmNvbHVtYmlhLmVkdQpodHRwczovL2xpc3RzLmNzLmNv bHVtYmlhLmVkdS9tYWlsbWFuL2xpc3RpbmZvL2t2bWFybQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e06smtp15.uk.ibm.com (e06smtp15.uk.ibm.com [195.75.94.111]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 621801A042B for ; Sat, 16 May 2015 01:58:52 +1000 (AEST) Received: from /spool/local by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 15 May 2015 16:58:48 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 9C3D717D805A for ; Fri, 15 May 2015 16:59:35 +0100 (BST) Received: from d06av04.portsmouth.uk.ibm.com (d06av04.portsmouth.uk.ibm.com [9.149.37.216]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t4FFwkIA10093002 for ; Fri, 15 May 2015 15:58:46 GMT Received: from d06av04.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av04.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t4FFweC5021317 for ; Fri, 15 May 2015 09:58:45 -0600 Message-ID: <555617AE.9030508@de.ibm.com> Date: Fri, 15 May 2015 17:58:38 +0200 From: Christian Borntraeger MIME-Version: 1.0 To: =?UTF-8?B?QWxleCBCZW5uw6ll?= , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, christoffer.dall@linaro.org, marc.zyngier@arm.com, peter.maydell@linaro.org, agraf@suse.de, drjones@redhat.com, pbonzini@redhat.com, zhichao.huang@linaro.org Subject: Re: [PATCH v4 02/12] KVM: define common KVM_GUESTDBG_USE_SW/HW_BP bits References: <1431700035-23479-1-git-send-email-alex.bennee@linaro.org> <1431700035-23479-3-git-send-email-alex.bennee@linaro.org> In-Reply-To: <1431700035-23479-3-git-send-email-alex.bennee@linaro.org> Content-Type: text/plain; charset=utf-8 Cc: Tony Krowiak , Alexey Kardashevskiy , Heiko Carstens , Bharat Bhushan , Paul Mackerras , "H. Peter Anvin" , linux-s390@vger.kernel.org, Michael Mueller , Nadav Amit , x86@kernel.org, Ingo Molnar , "Jason J. Herne" , jan.kiszka@siemens.com, Mihai Caraman , bp@suse.de, Gleb Natapov , r65777@freescale.com, Cornelia Huck , Thomas Gleixner , Eric Farman , linux-api@vger.kernel.org, open list , Dominik Dingel , dahi@linux.vnet.ibm.com, Martin Schwidefsky , linux390@de.ibm.com, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Am 15.05.2015 um 16:27 schrieb Alex Bennée: > index ef1a5fc..aca4f86 100644 > --- a/arch/s390/include/uapi/asm/kvm.h > +++ b/arch/s390/include/uapi/asm/kvm.h > @@ -114,8 +114,6 @@ struct kvm_fpu { > __u64 fprs[16]; > }; > > -#define KVM_GUESTDBG_USE_HW_BP 0x00010000 > - > diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h > index 70ac641..7c5dd11 100644 > --- a/include/uapi/linux/kvm.h > +++ b/include/uapi/linux/kvm.h [...] > +#define KVM_GUESTDBG_USE_SW_BP (1 << 16) > +#define KVM_GUESTDBG_USE_HW_BP (1 << 17) This is a abi break for s390, no? David do you remember why we did not use SW_BP? From mboxrd@z Thu Jan 1 00:00:00 1970 From: borntraeger@de.ibm.com (Christian Borntraeger) Date: Fri, 15 May 2015 17:58:38 +0200 Subject: [PATCH v4 02/12] KVM: define common KVM_GUESTDBG_USE_SW/HW_BP bits In-Reply-To: <1431700035-23479-3-git-send-email-alex.bennee@linaro.org> References: <1431700035-23479-1-git-send-email-alex.bennee@linaro.org> <1431700035-23479-3-git-send-email-alex.bennee@linaro.org> Message-ID: <555617AE.9030508@de.ibm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Am 15.05.2015 um 16:27 schrieb Alex Benn?e: > index ef1a5fc..aca4f86 100644 > --- a/arch/s390/include/uapi/asm/kvm.h > +++ b/arch/s390/include/uapi/asm/kvm.h > @@ -114,8 +114,6 @@ struct kvm_fpu { > __u64 fprs[16]; > }; > > -#define KVM_GUESTDBG_USE_HW_BP 0x00010000 > - > diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h > index 70ac641..7c5dd11 100644 > --- a/include/uapi/linux/kvm.h > +++ b/include/uapi/linux/kvm.h [...] > +#define KVM_GUESTDBG_USE_SW_BP (1 << 16) > +#define KVM_GUESTDBG_USE_HW_BP (1 << 17) This is a abi break for s390, no? David do you remember why we did not use SW_BP? From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Borntraeger Subject: Re: [PATCH v4 02/12] KVM: define common KVM_GUESTDBG_USE_SW/HW_BP bits Date: Fri, 15 May 2015 17:58:38 +0200 Message-ID: <555617AE.9030508@de.ibm.com> References: <1431700035-23479-1-git-send-email-alex.bennee@linaro.org> <1431700035-23479-3-git-send-email-alex.bennee@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Tony Krowiak , Alexey Kardashevskiy , Benjamin Herrenschmidt , Heiko Carstens , Paul Mackerras , "H. Peter Anvin" , linux-s390@vger.kernel.org, Michael Mueller , Nadav Amit , Michael Ellerman , x86@kernel.org, Ingo Molnar , "Jason J. Herne" , jan.kiszka@siemens.com, bp@suse.de, Gleb Natapov , r65777@freescale.com, Cornelia Huck , Thomas Gleixner , Eric Farman , linux-api@vger.kernel.org, open list , Dominik Dingel , dahi@linux.vnet.ibm.com, Martin Schwidefsky , To: =?UTF-8?B?QWxleCBCZW5uw6ll?= , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, christoffer.dall@linaro.org, marc.zyngier@arm.com, peter.maydell@linaro.org, agraf@suse.de, drjones@redhat.com, pbonzini@redhat.com, zhichao.huang@linaro.org Return-path: In-Reply-To: <1431700035-23479-3-git-send-email-alex.bennee@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu List-Id: kvm.vger.kernel.org QW0gMTUuMDUuMjAxNSB1bSAxNjoyNyBzY2hyaWViIEFsZXggQmVubsOpZToKPiBpbmRleCBlZjFh NWZjLi5hY2E0Zjg2IDEwMDY0NAo+IC0tLSBhL2FyY2gvczM5MC9pbmNsdWRlL3VhcGkvYXNtL2t2 bS5oCj4gKysrIGIvYXJjaC9zMzkwL2luY2x1ZGUvdWFwaS9hc20va3ZtLmgKPiBAQCAtMTE0LDgg KzExNCw2IEBAIHN0cnVjdCBrdm1fZnB1IHsKPiAgCV9fdTY0IGZwcnNbMTZdOwo+ICB9Owo+IAo+ IC0jZGVmaW5lIEtWTV9HVUVTVERCR19VU0VfSFdfQlAJCTB4MDAwMTAwMDAKPiAtCgoKPiBkaWZm IC0tZ2l0IGEvaW5jbHVkZS91YXBpL2xpbnV4L2t2bS5oIGIvaW5jbHVkZS91YXBpL2xpbnV4L2t2 bS5oCj4gaW5kZXggNzBhYzY0MS4uN2M1ZGQxMSAxMDA2NDQKPiAtLS0gYS9pbmNsdWRlL3VhcGkv bGludXgva3ZtLmgKPiArKysgYi9pbmNsdWRlL3VhcGkvbGludXgva3ZtLmgKWy4uLl0KPiArI2Rl ZmluZSBLVk1fR1VFU1REQkdfVVNFX1NXX0JQCQkoMSA8PCAxNikKPiArI2RlZmluZSBLVk1fR1VF U1REQkdfVVNFX0hXX0JQCQkoMSA8PCAxNykKClRoaXMgaXMgYSBhYmkgYnJlYWsgZm9yIHMzOTAs IG5vPwoKRGF2aWQgZG8geW91IHJlbWVtYmVyIHdoeSB3ZSBkaWQgbm90IHVzZSBTV19CUD8KCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmt2bWFybSBtYWls aW5nIGxpc3QKa3ZtYXJtQGxpc3RzLmNzLmNvbHVtYmlhLmVkdQpodHRwczovL2xpc3RzLmNzLmNv bHVtYmlhLmVkdS9tYWlsbWFuL2xpc3RpbmZvL2t2bWFybQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934897AbbEOP65 (ORCPT ); Fri, 15 May 2015 11:58:57 -0400 Received: from e06smtp13.uk.ibm.com ([195.75.94.109]:39808 "EHLO e06smtp13.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754865AbbEOP6x (ORCPT ); Fri, 15 May 2015 11:58:53 -0400 Message-ID: <555617AE.9030508@de.ibm.com> Date: Fri, 15 May 2015 17:58:38 +0200 From: Christian Borntraeger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: =?UTF-8?B?QWxleCBCZW5uw6ll?= , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, christoffer.dall@linaro.org, marc.zyngier@arm.com, peter.maydell@linaro.org, agraf@suse.de, drjones@redhat.com, pbonzini@redhat.com, zhichao.huang@linaro.org CC: jan.kiszka@siemens.com, dahi@linux.vnet.ibm.com, r65777@freescale.com, bp@suse.de, Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Martin Schwidefsky , Heiko Carstens , linux390@de.ibm.com, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Gleb Natapov , Bharat Bhushan , Alexey Kardashevskiy , Mihai Caraman , Cornelia Huck , Michael Mueller , Eric Farman , Dominik Dingel , Tony Krowiak , "Jason J. Herne" , Nadav Amit , linuxppc-dev@lists.ozlabs.org, open list , linux-s390@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: [PATCH v4 02/12] KVM: define common KVM_GUESTDBG_USE_SW/HW_BP bits References: <1431700035-23479-1-git-send-email-alex.bennee@linaro.org> <1431700035-23479-3-git-send-email-alex.bennee@linaro.org> In-Reply-To: <1431700035-23479-3-git-send-email-alex.bennee@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15051515-0013-0000-0000-000003FE15EF Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 15.05.2015 um 16:27 schrieb Alex Bennée: > index ef1a5fc..aca4f86 100644 > --- a/arch/s390/include/uapi/asm/kvm.h > +++ b/arch/s390/include/uapi/asm/kvm.h > @@ -114,8 +114,6 @@ struct kvm_fpu { > __u64 fprs[16]; > }; > > -#define KVM_GUESTDBG_USE_HW_BP 0x00010000 > - > diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h > index 70ac641..7c5dd11 100644 > --- a/include/uapi/linux/kvm.h > +++ b/include/uapi/linux/kvm.h [...] > +#define KVM_GUESTDBG_USE_SW_BP (1 << 16) > +#define KVM_GUESTDBG_USE_HW_BP (1 << 17) This is a abi break for s390, no? David do you remember why we did not use SW_BP?