From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <michael.g.wood@intel.com>
Received: by yocto-www.yoctoproject.org (Postfix, from userid 118)
	id 5BBE6E00960; Fri, 15 May 2015 09:53:03 -0700 (PDT)
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on
	yocto-www.yoctoproject.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE
	autolearn=ham version=3.3.1
X-Spam-HAM-Report: * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
	*      [score: 0.0000]
	* -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,
	no *      trust
	*      [74.125.82.45 listed in list.dnswl.org]
Received: from mail-wg0-f45.google.com (mail-wg0-f45.google.com [74.125.82.45])
	by yocto-www.yoctoproject.org (Postfix) with ESMTP id D8709E00945
	for <toaster@yoctoproject.org>; Fri, 15 May 2015 09:53:00 -0700 (PDT)
Received: by wguv19 with SMTP id v19so57601485wgu.1
	for <toaster@yoctoproject.org>; Fri, 15 May 2015 09:52:59 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20130820;
	h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to
	:subject:references:in-reply-to:content-type
	:content-transfer-encoding;
	bh=EyyNijmlqwRFN+yb0MNXofq+sDRJXirA66/bDkOdWxQ=;
	b=HH+cdjIt9WNxF0OvA/KaNjBdD5/acYXGrMWQhKQN9WuJAPAYWlboC9OphD+RYBcf/X
	o+GNqnJxKNIpn4i0NPK087YHQTrYnrF6r4iLR83Oc2AHrTDlJftQzs0IGzcUVzLVBqcZ
	VEOsb4IppYXeWAHVhxmmjJQksiXiAciJIYy3BFFX6BAzqK9Mu6LPQrVXi8xLqeMVCAjr
	ZyKgoVQZIrO7fEVvcudDlv1QxcZy6HpxYylnIyTSnbDFacc9PXHCOFBpjZCTzhctEoIn
	uhGp0zY5w/WJZSMhof1odtumJ0n41YnWoxeC2w/gLbVp7FTNj3EkXXWtbAm1vKag1R7/
	myJQ==
X-Gm-Message-State: ALoCoQkXDJL1BzJH5/0hFzpzizm8ZZ4dd6dGuCCtB7TwMqYfdfWfCv/2N7gcEhwmZvg2vqWqILjC
X-Received: by 10.180.218.108 with SMTP id pf12mr61359946wic.13.1431708779778; 
	Fri, 15 May 2015 09:52:59 -0700 (PDT)
Received: from [192.168.2.24] ([83.217.123.106])
	by mx.google.com with ESMTPSA id n1sm3778925wix.0.2015.05.15.09.52.59
	for <toaster@yoctoproject.org>
	(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
	Fri, 15 May 2015 09:52:59 -0700 (PDT)
Message-ID: <5556246A.6090606@intel.com>
Date: Fri, 15 May 2015 17:52:58 +0100
From: Michael Wood <michael.g.wood@intel.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: toaster@yoctoproject.org
References: <CAJ2CSBuVEYFzG5jrRLNQ0du+LvYhXR+Ny0x5MbFY9NX7i_4=_g@mail.gmail.com>
In-Reply-To: <CAJ2CSBuVEYFzG5jrRLNQ0du+LvYhXR+Ny0x5MbFY9NX7i_4=_g@mail.gmail.com>
Subject: Re: [review-request] adamian/20150515_fix_table_header
X-BeenThere: toaster@yoctoproject.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: Web based interface for BitBake <toaster.yoctoproject.org>
List-Unsubscribe: <https://lists.yoctoproject.org/options/toaster>,
	<mailto:toaster-request@yoctoproject.org?subject=unsubscribe>
List-Archive: <http://lists.yoctoproject.org/pipermail/toaster>
List-Post: <mailto:toaster@yoctoproject.org>
List-Help: <mailto:toaster-request@yoctoproject.org?subject=help>
List-Subscribe: <https://lists.yoctoproject.org/listinfo/toaster>,
	<mailto:toaster-request@yoctoproject.org?subject=subscribe>
X-List-Received-Date: Fri, 15 May 2015 16:53:03 -0000
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit


This wouldn't be valid html as it'll do:

<thead id="tableheader">
     <th>dog</th>
</thead>

When it should be

<thead id="tableheader">
    <tr>
        <th>dog</th>
     </tr>
</thead>

Just put an empty <th> in the <tr> that should be valid then.

diff --git a/bitbake/lib/toaster/toastergui/templates/toastertable.html 
b/bitbake/lib/toaster/toastergui/templates/toastertable.html
index 598d295..d68d093 100644
--- a/bitbake/lib/toaster/toastergui/templates/toastertable.html
+++ b/bitbake/lib/toaster/toastergui/templates/toastertable.html
@@ -93,6 +93,7 @@
    <!-- The actual table -->
    <table class="table table-bordered table-hover tablesorter" 
id="{{table_name}}">
      <thead>
+      <tr><th></th></tr>
      </thead>
      <tbody></tbody>
    </table>


Michael

On 15/05/15 14:45, Damian, Alexandru wrote:
> Hi,
>
> This patch brings back table header in the toastertable - based pages.
>
> Can you please review ?
>
> Thank you,
> Alex
>
> -- 
> Alex Damian
> Yocto Project
> SSG / OTC
>
>