All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Baron <jbaron@akamai.com>
To: Eric Dumazet <edumazet@google.com>,
	"David S. Miller" <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>,
	Neal Cardwell <ncardwell@google.com>,
	Yuchung Cheng <ycheng@google.com>,
	Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH v2 net-next 0/6] tcp: better handling of memory pressure
Date: Fri, 15 May 2015 17:20:22 -0400	[thread overview]
Message-ID: <55566316.5020800@akamai.com> (raw)
In-Reply-To: <1431718770-3815-1-git-send-email-edumazet@google.com>

Ok, feel free to add:

Acked-by: Jason Baron <jbaron@akamai.com>

Also, I sent as a separate patch:

Subject: [PATCH] tcp: ensure epoll edge trigger wakeup when out of memory

This does the wakeup in the case where we really can't allocate the
memory to see what you think of that idea. I didn't test it, but wanted
to see what you thought.

Thanks,

-Jason

On 05/15/2015 03:39 PM, Eric Dumazet wrote:
> When testing commit 790ba4566c1a ("tcp: set SOCK_NOSPACE under memory
> pressure") using edge triggered epoll applications, I found various
> issues under memory pressure and thousands of active sockets.
>
> This patch series is a first round to solve these issues, in send
> and receive paths. There are probably other fixes needed, but
> with this series, my tests now all succeed.
>
> v2: fix typo in "allow one skb to be received per socket under memory pressure",
> as spotted by Jason Baron.
>
> Eric Dumazet (6):
>   net: fix sk_mem_reclaim_partial()
>   tcp: rename sk_forced_wmem_schedule() to sk_forced_mem_schedule()
>   tcp: introduce tcp_under_memory_pressure()
>   tcp: fix behavior for epoll edge trigger
>   tcp: allow one skb to be received per socket under memory pressure
>   tcp: halves tcp_mem[] limits
>
>  include/net/sock.h    |  6 +++---
>  include/net/tcp.h     | 10 ++++++++++
>  net/core/sock.c       |  9 +++++----
>  net/ipv4/tcp.c        | 24 ++++++++++++++++++------
>  net/ipv4/tcp_input.c  | 18 ++++++++++--------
>  net/ipv4/tcp_output.c | 10 ++++++----
>  net/ipv4/tcp_timer.c  |  2 +-
>  7 files changed, 53 insertions(+), 26 deletions(-)
>

  parent reply	other threads:[~2015-05-15 21:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-15 19:39 [PATCH v2 net-next 0/6] tcp: better handling of memory pressure Eric Dumazet
2015-05-15 19:39 ` [PATCH v2 net-next 1/6] net: fix sk_mem_reclaim_partial() Eric Dumazet
2015-08-03 20:53   ` Jason Baron
2015-05-15 19:39 ` [PATCH v2 net-next 2/6] tcp: rename sk_forced_wmem_schedule() to sk_forced_mem_schedule() Eric Dumazet
2015-05-15 19:39 ` [PATCH v2 net-next 3/6] tcp: introduce tcp_under_memory_pressure() Eric Dumazet
2015-05-15 19:39 ` [PATCH v2 net-next 4/6] tcp: fix behavior for epoll edge trigger Eric Dumazet
2015-05-15 19:39 ` [PATCH v2 net-next 5/6] tcp: allow one skb to be received per socket under memory pressure Eric Dumazet
2015-05-15 19:39 ` [PATCH v2 net-next 6/6] tcp: halves tcp_mem[] limits Eric Dumazet
2015-05-15 21:20 ` Jason Baron [this message]
2015-05-18  2:46 ` [PATCH v2 net-next 0/6] tcp: better handling of memory pressure David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55566316.5020800@akamai.com \
    --to=jbaron@akamai.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=ycheng@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.