From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58640) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yu0FV-0007n3-8v for qemu-devel@nongnu.org; Sun, 17 May 2015 11:13:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yu0FR-0003OH-7L for qemu-devel@nongnu.org; Sun, 17 May 2015 11:13:05 -0400 Received: from cantor2.suse.de ([195.135.220.15]:39055 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yu0FQ-0003Nl-TZ for qemu-devel@nongnu.org; Sun, 17 May 2015 11:13:01 -0400 Message-ID: <5558AFF1.6080206@suse.de> Date: Sun, 17 May 2015 17:12:49 +0200 From: =?windows-1252?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <5b1feadab1338f3b9eeba73704e7996fd096bb0c.1431583229.git.alistair.francis@xilinx.com> <5555D54A.9080000@suse.de> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC v1 3/3] target-microblaze: Convert use-fpu to a CPU property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alistair Francis Cc: Edgar Iglesias , Peter Crosthwaite , "qemu-devel@nongnu.org Developers" Am 17.05.2015 um 14:26 schrieb Alistair Francis: > On Fri, May 15, 2015 at 9:15 PM, Andreas F=E4rber wr= ote: >> Am 15.05.2015 um 08:36 schrieb Alistair Francis: >>> On Fri, May 15, 2015 at 4:32 PM, Peter Crosthwaite >>> wrote: >>>> On Thu, May 14, 2015 at 10:56 PM, Alistair Francis >>>> wrote: >>>>> On Fri, May 15, 2015 at 3:52 PM, Peter Crosthwaite >>>>> wrote: >>>>>> On Thu, May 14, 2015 at 10:48 PM, Alistair Francis >>>>>> wrote: >>>>>>> On Fri, May 15, 2015 at 3:22 PM, Peter Crosthwaite >>>>>>> wrote: >>>>>>>> On Wed, May 13, 2015 at 11:08 PM, Alistair Francis >>>>>>>> wrote: >>>>>>>>> | PVR2_FPU_EXC_MASK \ >>>>>>>>> | 0; >>>>>>>>> + >>>>>>>>> + if (cpu->cfg.usefpu) { >>>>>>>>> + env->pvr.regs[0] |=3D PVR0_USE_FPU_MASK; >>>>>>>>> + env->pvr.regs[2] |=3D PVR2_USE_FPU_MASK; >>>>>>>>> + >>>>>>>>> + if (cpu->cfg.usefpu > 1) { >>>>>>>>> + env->pvr.regs[2] |=3D PVR2_USE_FPU2_MASK; >>>>>>>>> + } >>>>>>>>> + } >>>>>>>> >>>>>>>> This should be handled at realize time. See pl330_realize for ex= ample >>>>>>>> of realize-time PVR ("cfg" in that case) population. >>>>>>> >>>>>>> But the env state gets wiped out at reset, so the information wil= l be lost. >>>>>> >>>>>> Ahh, so the solution there is to do what ARM does and have a secti= on >>>>>> at the back of the env which survives reset. Check the memset in >>>>>> arm_cpu_reset. >>>>> >>>>> Ok, just to clarify we want all of the pvr registers to be preserve= d on reset? >>>> >>>> yes. But something that just occured to me, does it make sense to mo= ve >>>> it outside the env? into the CPUState? Andreas mentioned that fields >>>> in the CPU state before the env can be used with negative env* offse= ts >>>> by translated code. This means the PVR could just be pushed up to >>>> CPUState. >>> >>> Do any other machines do that? >>> >>> I'm happy with leaving it in the env (partly because I just did it) >>> and it also matches the way that ARM does it. >> >> All targets had everything in env originally, so that's not really an >> argument for anything. You need to decide what makes sense for your >> target - icount is an example using negative offsets in CPUState now, >> whereas TCGv* variables declared via offset from env remained in env. >=20 > I think env makes sense in this case, especially as the > DEFINE_PROP_UINT8() macro defaults to setting variables in the env > structure. Admittedly I haven't looked into it, so it might be just as > easy to set variables in the MicroBlazeCPU. In fact the CPU properties operate on MicroBlazeCPU. The legacy properties thus need an explicit env.foo as macro argument. But as usual things can be done in multiple steps. Andreas > I have another patch set ready to send out tomorrow with all of the > variables in env. We can decide from there if they should be moved to > the MicroBlazeCPU struct. >=20 > Thanks, >=20 > Alistair --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)