From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751373AbbEQSyX (ORCPT ); Sun, 17 May 2015 14:54:23 -0400 Received: from mail-pd0-f173.google.com ([209.85.192.173]:34019 "EHLO mail-pd0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751183AbbEQSyQ (ORCPT ); Sun, 17 May 2015 14:54:16 -0400 Message-ID: <5558E3D2.30708@kernel.dk> Date: Sun, 17 May 2015 12:54:10 -0600 From: Jens Axboe User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Nicholas Krause CC: linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND] block:Add proper error checking to the function, add_disk References: <1431862557-3325-1-git-send-email-xerofoify@gmail.com> In-Reply-To: <1431862557-3325-1-git-send-email-xerofoify@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/17/2015 05:35 AM, Nicholas Krause wrote: > This adds proper error checking and handling to the function, > add_disk by changing the return from void to a int. In addition > we also change various WARN_ON statements in this function to > proper if statements that now return a error code if there > condition arises during this function's run. Finally we change > the function prototype in genhd.h to return an int now rather > then void. Nick, I'm not going to keep looking at these. It's quite clear you are out of your depth, hence the review to reward ratio (as a maintainer) is just too high. This is the 3rd iteration of this patch in a few days, all different, and no comments or version logs. So please stop fixing FIXME patches for the block are, thanks. This message does not require a reply. -- Jens Axboe