Re: [PATCH 2/2] drm: bridge/dw_hdmi: add dw hdmi i2c bus adapter support

From: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
To: Philipp Zabel <p.zabel@pengutronix.de>,
	David Airlie <airlied@linux.ie>,
	Russell King <rmk+kernel@arm.linux.org.uk>,
	Andy Yan <andy.yan@rock-chips.com>,
	Yakir Yang <ykk@rock-chips.com>,
	Fabio Estevam <fabio.estevam@freescale.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm: bridge/dw_hdmi: add dw hdmi i2c bus adapter support
Date: Sun, 17 May 2015 22:17:54 +0300	[thread overview]
Message-ID: <5558E962.9020601@mentor.com> (raw)
In-Reply-To: <1431885807-29887-3-git-send-email-vladimir_zapolskiy@mentor.com>

On 17.05.2015 21:03, Vladimir Zapolskiy wrote:
> The change adds support of internal HDMI I2C master controller, this
> subdevice is used by default, if "ddc-i2c-bus" DT property is omitted.
> 
> The main purpose of this functionality is to support reading EDID from
> an HDMI monitor on boards, which don't have an I2C bus connected to
> DDC pins.
> 
> Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
> ---
>  drivers/gpu/drm/bridge/dw_hdmi.c | 332 ++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 326 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c
> index 49cafb6..2a52449 100644
> --- a/drivers/gpu/drm/bridge/dw_hdmi.c
> +++ b/drivers/gpu/drm/bridge/dw_hdmi.c

[snip]

> +	ret = i2c_add_adapter(adap);
> +	if (ret) {
> +		dev_warn(hdmi->dev, "cannot add %s I2C adapter\n", adap->name);
> +		devm_kfree(hdmi->i2c);

Immediately found a compilation problem in last minute update, I'll
resend the change, sorry.

> +		hdmi->i2c = NULL;
> +		return ERR_PTR(ret);
> +	}
> +

--
With best wishes,
Vladimir
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel