All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guoqing Jiang <gqJiang@suse.com>
To: NeilBrown <neilb@suse.de>
Cc: linux-raid@vger.kernel.org, rgoldwyn@suse.de
Subject: Re: [PATCH V2 01/11] Create n bitmaps for clustered mode
Date: Mon, 18 May 2015 10:21:00 +0800	[thread overview]
Message-ID: <55594C8C.904@suse.com> (raw)
In-Reply-To: <20150515154527.7751f765@notabene.brown>

NeilBrown wrote:
>> diff --git a/mdadm.c b/mdadm.c
>> index 3e8c49b..bd9382e 100644
>> --- a/mdadm.c
>> +++ b/mdadm.c
>> @@ -1097,6 +1097,15 @@ int main(int argc, char *argv[])
>>  				s.bitmap_file = optarg;
>>  				continue;
>>  			}
>> +			if (strcmp(optarg, "clustered")== 0) {
>> +				s.bitmap_file = optarg;
>> +				/* Set the default number of cluster nodes
>> +				 * to 4 if not already set by user
>> +				 */
>> +				if (c.nodes < 1)
>> +					c.nodes = 4;
>> +				continue;
>> +			}
>>     
>
>
> Please make sure than mdadm compiles after each patch is applied.
> You don't defined that 'nodes' field until a later patch.
>
>   
Oops, I will fix it in next version.

Thanks,
Guoqing
> NeilBrown
>
>   


  reply	other threads:[~2015-05-18  2:21 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-08  8:50 [PATCH V2 00/11] mdadm tool: add the support for cluster-md gqjiang
2015-05-08  8:50 ` [PATCH V2 01/11] Create n bitmaps for clustered mode gqjiang
2015-05-15  5:45   ` NeilBrown
2015-05-18  2:21     ` Guoqing Jiang [this message]
2015-05-08  8:50 ` [PATCH V2 02/11] Add nodes option while creating md gqjiang
2015-05-08  8:50 ` [PATCH V2 03/11] home-cluster while creating an array gqjiang
2015-05-08  8:50 ` [PATCH V2 04/11] Show all bitmaps while examining bitmap gqjiang
2015-05-08  8:50 ` [PATCH V2 05/11] Add a new clustered disk gqjiang
2015-05-08  8:50 ` [PATCH V2 06/11] Convert a bitmap=none device to clustered gqjiang
2015-05-08  8:50 ` [PATCH V2 07/11] Skip clustered devices in incremental gqjiang
2015-05-08  8:50 ` [PATCH V2 08/11] mdadm: add the ability to change cluster name gqjiang
2015-05-08  8:50 ` [PATCH V2 09/11] mdadm: change the num of cluster node gqjiang
2015-05-08  8:50 ` [PATCH V2 10/11] Reuse calc_bitmap_size to reduce code size gqjiang
2015-05-08  8:50 ` [PATCH V2 11/11] Reuse the write_bitmap for update uuid gqjiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55594C8C.904@suse.com \
    --to=gqjiang@suse.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=rgoldwyn@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.