From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35078)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhaoshenglong@huawei.com>) id 1YuCJs-0004Ii-MG
	for qemu-devel@nongnu.org; Mon, 18 May 2015 00:06:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <zhaoshenglong@huawei.com>) id 1YuCJo-00078K-DD
	for qemu-devel@nongnu.org; Mon, 18 May 2015 00:06:24 -0400
Received: from szxga01-in.huawei.com ([58.251.152.64]:25578)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhaoshenglong@huawei.com>) id 1YuCJn-00076U-MJ
	for qemu-devel@nongnu.org; Mon, 18 May 2015 00:06:20 -0400
Message-ID: <5559651D.6030407@huawei.com>
Date: Mon, 18 May 2015 12:05:49 +0800
From: Shannon Zhao <zhaoshenglong@huawei.com>
MIME-Version: 1.0
References: <1430990964-10528-1-git-send-email-zhaoshenglong@huawei.com>	<1430990964-10528-6-git-send-email-zhaoshenglong@huawei.com>	<CAFEAcA_RpG69nQghzcnqa7pMDMJQ5t=dTzys9nab+nzv_0aWmg@mail.gmail.com>
	<20150515141417.4b6d01ff@nial.brq.redhat.com>
In-Reply-To: <20150515141417.4b6d01ff@nial.brq.redhat.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v6 05/22] hw/acpi/aml-build: Add
 aml_interrupt() term
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>, Peter Maydell <peter.maydell@linaro.org>
Cc: hangaohuai@huawei.com, Laszlo Ersek <lersek@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Alexander Spyridakis <a.spyridakis@virtualopensystems.com>, Claudio Fontana <claudio.fontana@huawei.com>, "Huangpeng (Peter)" <peter.huangpeng@huawei.com>, QEMU Developers <qemu-devel@nongnu.org>, Hanjun Guo <hanjun.guo@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, =?ISO-8859-1?Q?Alex_?= =?ISO-8859-1?Q?Benn=E9e?= <alex.bennee@linaro.org>, Christoffer Dall <christoffer.dall@linaro.org>, Shannon Zhao <shannon.zhao@linaro.org>

On 2015/5/15 20:14, Igor Mammedov wrote:
> On Thu, 7 May 2015 16:51:31 +0100
> Peter Maydell <peter.maydell@linaro.org> wrote:
> 
>> > On 7 May 2015 at 10:29, Shannon Zhao <zhaoshenglong@huawei.com> wrote:
>>> > > From: Shannon Zhao <shannon.zhao@linaro.org>
>>> > >
>>> > > Add aml_interrupt() for describing device interrupt in resource template.
>>> > > These can be used to generating DSDT table for ACPI on ARM.
>> > 
>>> > > +    /* Interrupt Number */
>>> > > +    build_append_byte(var->buf, extract32(irq, 0, 8)); /* bits[7:0] */
>>> > > +    build_append_byte(var->buf, extract32(irq, 8, 8)); /* bits[15:8] */
>>> > > +    build_append_byte(var->buf, extract32(irq, 16, 8)); /* bits[23:16] */
>>> > > +    build_append_byte(var->buf, extract32(irq, 24, 8)); /* bits[31:24] */
>> > 
>> > You used this twice in the previous patch and again here. Can
>> > we factor it out so we can
>> >   build_append_uint32(var->buf, irq);
> I'd prefer to leave it as it is now, yes it's a bit of code duplication
> but when you compare to spec it's 1:1 match and easy to compare
> 

I think we could use build_append_uint32 because this really makes the
code cleaner and it also matches the spec. When comparing to the spec,
uint32 means 4 bytes, so it implies that it includes this byte and next
3 bytes and it also says the 4 bytes are integral.

-- 
Shannon