From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753728AbbERLhQ (ORCPT ); Mon, 18 May 2015 07:37:16 -0400 Received: from smtp81.iad3a.emailsrvr.com ([173.203.187.81]:33859 "EHLO smtp81.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750858AbbERLhM (ORCPT ); Mon, 18 May 2015 07:37:12 -0400 X-Sender-Id: abbotti@mev.co.uk Message-ID: <5559CEE5.8040102@mev.co.uk> Date: Mon, 18 May 2015 12:37:09 +0100 From: Ian Abbott User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0 MIME-Version: 1.0 To: Geliang Tang , hsweeten@visionengravers.com, gregkh@linuxfoundation.org CC: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: comedi: fix coding style issues References: <1431749763-2378-1-git-send-email-geliangtang@163.com> In-Reply-To: <1431749763-2378-1-git-send-email-geliangtang@163.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/05/15 05:16, Geliang Tang wrote: > 1) Fixed an error found by checkpatch.pl. > ERROR: space required after that ',' (ctx:VxV) > ./drivers/ni_mio_common.c:3764 > 2) Changed "register 0x%x" to "register=0x%x" to keep the consistency > of this file. > 3) The kernel version is next-20150515, 4.1.0-rc3. You shouldn't mention point 3 in the commit message as it will look a bit strange when it ends up in the commit log. If you need to mention that, it should go after the commit message, separated from the patch by a "---" line like this: Body of commit message goes here. Signed off by and Cc lines go here. --- Additional patch commentary goes here. --- Actual patch goes here. Git will ignore the additional commentary when the patch is applied. > > Signed-off-by: Geliang Tang > --- > drivers/staging/comedi/drivers/ni_mio_common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c b/drivers/staging/comedi/drivers/ni_mio_common.c > index 9dfd4e6..6cc304a 100644 > --- a/drivers/staging/comedi/drivers/ni_mio_common.c > +++ b/drivers/staging/comedi/drivers/ni_mio_common.c > @@ -3761,7 +3761,7 @@ static unsigned int ni_gpct_to_stc_register(struct comedi_device *dev, > if (reg < ARRAY_SIZE(ni_gpct_to_stc_regmap)) { > regmap = &ni_gpct_to_stc_regmap[reg]; > } else { > - dev_warn(dev->class_dev,"%s: unhandled register 0x%x\n", > + dev_warn(dev->class_dev, "%s: unhandled register=0x%x\n", > __func__, reg); > return 0; > } > Apart from that niggle, the patch looks good! Reviewed-by: Ian Abbott -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-