Re: [Qemu-devel] [PATCH] keyboard: handle ps2 typing buffer overrun

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1068 bytes --]

On 05/18/2015 06:54 AM, Eric Blake wrote:
> On 05/17/2015 10:00 AM, penghao122@sina.com wrote:
>> Subject: [PATCH] keyboard: handle ps2 typing buffer overrun
> 
> This line is redundant.
> 
> Also, you have tried to send this patch more than once.  Please be sure
> to include a proper 'v3' or 'v4' in the subject line, as appropriate.
> 
>> Starting a linux guest with ps2 keyboard, if you type many times during leaving
>> grub and into linux kernel,then you can't use keyboard after linux initialization finished.
>> Specally when you setup linux guest from iso file,you will type in grub.
> 
> s/Specally/Specifically,/
> s/file,you/file, you/

In fact, I called these out on your v2 submission.
https://lists.gnu.org/archive/html/qemu-devel/2015-05/msg00938.html

Sending a v3 without addressing points made in v2 is not good - it
wastes everyone's time, and makes it more likely that your patch will be
intentionally overlooked.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]