From: Guenter Roeck <linux@roeck-us.net>
To: Denys Vlasenko <dvlasenk@redhat.com>,
Vijaya Mohan Guvva <vmohan@brocade.com>
Cc: Fabian Frederick <fabf@skynet.be>,
Anil Gurumurthy <anil.gurumurthy@qlogic.com>,
Christoph Hellwig <hch@lst.de>,
Ben Hutchings <ben@decadent.org.uk>,
James Bottomley <JBottomley@Parallels.com>,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] bfa: deinline __bfa_trc() and __bfa_trc32()
Date: Mon, 18 May 2015 05:58:35 -0700 [thread overview]
Message-ID: <5559E1FB.2070004@roeck-us.net> (raw)
In-Reply-To: <1431940681-15915-1-git-send-email-dvlasenk@redhat.com>
On 05/18/2015 02:18 AM, Denys Vlasenko wrote:
> __bfa_trc() compiles to 115 bytes of machine code.
> With this .config: http://busybox.net/~vda/kernel_config
> there are 1494 calls of __bfa_trc().
>
> __bfa_trc32() is very similar, so it is uninlined too.
> However, it appears to be unused, therefore this patch
> ifdefs it out.
>
Why not just remove it ?
Guenter
next prev parent reply other threads:[~2015-05-18 12:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 9:18 [PATCH] bfa: deinline __bfa_trc() and __bfa_trc32() Denys Vlasenko
2015-05-18 12:58 ` Guenter Roeck [this message]
2015-05-18 13:01 ` Denys Vlasenko
2015-05-19 10:43 ` Anil Gurumurthy
2015-05-19 10:43 ` Anil Gurumurthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5559E1FB.2070004@roeck-us.net \
--to=linux@roeck-us.net \
--cc=JBottomley@Parallels.com \
--cc=anil.gurumurthy@qlogic.com \
--cc=ben@decadent.org.uk \
--cc=dvlasenk@redhat.com \
--cc=fabf@skynet.be \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=vmohan@brocade.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.