From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH V3 1/6] libxl: export some functions for pvusb use Date: Mon, 18 May 2015 14:34:19 +0100 Message-ID: <5559EA5B.5000103@eu.citrix.com> References: <1429415452-6161-1-git-send-email-cyliu@suse.com> <1429415452-6161-2-git-send-email-cyliu@suse.com> <20150420162505.GA31885@aepfle.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150420162505.GA31885@aepfle.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Olaf Hering , xen-devel@lists.xen.org Cc: ian.jackson@citrix.com, wei.liu2@citrix.com, ian.campbell@citrix.com, Chunyan Liu List-Id: xen-devel@lists.xenproject.org On 04/20/2015 05:25 PM, Olaf Hering wrote: > On Sun, Apr 19, Chunyan Liu wrote: > >> +++ b/tools/libxl/libxl_internal.h > >> +_hidden int libxl__device_nextid(libxl__gc *gc, uint32_t domid, char *device); >> +_hidden int libxl__resolve_domid(libxl__gc *gc, const char *name, >> + uint32_t *domid); > >> +/* generic callback for devices that only need to set ao_complete */ >> +_hidden void device_addrm_aocomplete(libxl__egc *egc, libxl__ao_device *aodev); > > If that goes in I may move some or all of the vscsi code in libxl.c into > libxl_vscsi.c. It sounds like this would be useful independent of the pvusb stuff. -George