From: "Holger Hoffstätte" <holger.hoffstaette@googlemail.com>
To: Theodore Ts'o <tytso@mit.edu>, Karel Zak <kzak@redhat.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: Lazytime undone by/not working with remount?
Date: Mon, 18 May 2015 17:38:27 +0200 [thread overview]
Message-ID: <555A0773.9010905@googlemail.com> (raw)
In-Reply-To: <20150518152309.GB4180@thunk.org>
On 05/18/15 17:23, Theodore Ts'o wrote:
> On Mon, May 18, 2015 at 10:21:35AM +0200, Karel Zak wrote:
>> I see the problem on another place. The ext4 fs driver has unique
>> feature that it's able to accept "lazytime" option as string
>> (util-linux < 2.26.2) as well as MS_LAZYTIME vfs flag (>= 2.26.2).
>>
>> IMHO the function ext4_remount() does not check VFS *flags for
>> MS_LAZYTIME at all. The code probably cares about sb->s_flags only
>> (these flags are generated by parse_options() when parse options
>> string). It seems that only MS_RDONLY is expected in *flags.
>
> Yep, the bug is on my side, in ext4_remount(). I'll get this fixed
> and marked as something that should get bacported to the stable tree.
> My apologies for the oversight.
Thanks for confirming, Ted! I'll gladly test a patch for 4.0.x.
-h
prev parent reply other threads:[~2015-05-18 15:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-16 11:05 Lazytime undone by/not working with remount? Holger Hoffstätte
2015-05-16 14:26 ` Holger Hoffstätte
[not found] ` <55575399.6010801@googlemail.com>
2015-05-18 8:21 ` Karel Zak
2015-05-18 15:18 ` Eric Sandeen
2015-05-18 15:36 ` Holger Hoffstätte
2015-05-18 15:23 ` Theodore Ts'o
2015-05-18 15:38 ` Holger Hoffstätte [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555A0773.9010905@googlemail.com \
--to=holger.hoffstaette@googlemail.com \
--cc=kzak@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.