From: Richard Henderson <rth@twiddle.net>
To: Aurelien Jarno <aurelien@aurel32.net>, qemu-devel@nongnu.org
Cc: Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH 1/3] target-s390x: fix CC computation for LOAD POSITIVE instructions
Date: Mon, 18 May 2015 08:42:05 -0700 [thread overview]
Message-ID: <555A084D.8030501@twiddle.net> (raw)
In-Reply-To: <1431956400-19091-1-git-send-email-aurelien@aurel32.net>
On 05/18/2015 06:39 AM, Aurelien Jarno wrote:
> LOAD POSITIVE instructions (LPR, LPGR and LPGFR) set the following
> condition code:
> 0: Result zero; no overflow
> 1: --
> 2: Result greater than zero; no overflow
> 3: Overflow
>
> The current code wrongly returns 1 instead of 2 in case of a result
> greater than 0. This patches fixes that. This fixes the marshalling of
> the value '0L' in Python.
>
> Cc: Richard Henderson <rth@twiddle.net>
> Cc: Alexander Graf <agraf@suse.de>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
> target-s390x/cc_helper.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
next prev parent reply other threads:[~2015-05-18 15:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 13:39 [Qemu-devel] [PATCH 1/3] target-s390x: fix CC computation for LOAD POSITIVE instructions Aurelien Jarno
2015-05-18 13:39 ` [Qemu-devel] [PATCH 2/3] target-s390x: optimize (negative-) abs computation Aurelien Jarno
2015-05-18 15:42 ` Richard Henderson
2015-05-18 13:40 ` [Qemu-devel] [PATCH 3/3] target-s390x: remove unused helpers Aurelien Jarno
2015-05-18 15:42 ` Richard Henderson
2015-05-18 15:42 ` Richard Henderson [this message]
2015-05-18 17:04 ` [Qemu-devel] [PATCH 1/3] target-s390x: fix CC computation for LOAD POSITIVE instructions Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555A084D.8030501@twiddle.net \
--to=rth@twiddle.net \
--cc=agraf@suse.de \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.