From: Richard Henderson <rth@twiddle.net>
To: Peter Crosthwaite <crosthwaitepeter@gmail.com>,
qemu-devel@nongnu.org, armbru@redhat.com, lcapitulino@redhat.com,
afaerber@suse.de
Cc: Peter Crosthwaite <crosthwaite.peter@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] monitor: Split mon_get_cpu fn to remove ENV_GET_CPU
Date: Mon, 18 May 2015 09:13:04 -0700 [thread overview]
Message-ID: <555A0F90.1060603@twiddle.net> (raw)
In-Reply-To: <1eddf7c8960c0082d7db599ff3486224a3e6635d.1431891113.git.crosthwaite.peter@gmail.com>
On 05/17/2015 12:51 PM, Peter Crosthwaite wrote:
> @@ -1208,7 +1203,6 @@ static void monitor_printc(Monitor *mon, int c)
> static void memory_dump(Monitor *mon, int count, int format, int wsize,
> hwaddr addr, int is_physical)
> {
> - CPUArchState *env;
> int l, line_size, i, max_digits, len;
> uint8_t buf[16];
> uint64_t v;
> @@ -1216,8 +1210,8 @@ static void memory_dump(Monitor *mon, int count, int format, int wsize,
> if (format == 'i') {
> int flags;
> flags = 0;
> - env = mon_get_cpu();
> #ifdef TARGET_I386
> + CPUArchState *env = mon_get_env();
> if (wsize == 2) {
C99 declaration after statement. I forget if we care or not?
Anyway, fixable by changing the line above to
int flags = 0;
Otherwise,
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
next prev parent reply other threads:[~2015-05-18 16:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-17 19:51 [Qemu-devel] [PATCH 0/2] monitor+disas: Remove uses of ENV_GET_CPU Peter Crosthwaite
2015-05-17 19:51 ` [Qemu-devel] [PATCH 1/2] monitor: Split mon_get_cpu fn to remove ENV_GET_CPU Peter Crosthwaite
2015-05-18 16:13 ` Richard Henderson [this message]
2015-05-18 16:44 ` Peter Crosthwaite
2015-05-18 16:52 ` Andreas Färber
2015-05-24 20:30 ` Peter Crosthwaite
2015-05-17 19:51 ` [Qemu-devel] [PATCH 2/2] disas: Remove uses of CPU env Peter Crosthwaite
2015-05-18 16:15 ` Richard Henderson
2015-05-18 17:20 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555A0F90.1060603@twiddle.net \
--to=rth@twiddle.net \
--cc=afaerber@suse.de \
--cc=armbru@redhat.com \
--cc=crosthwaite.peter@gmail.com \
--cc=crosthwaitepeter@gmail.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.